Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303553003: Enable mute button, even if preferring hidden volume slider. (Closed)

Created:
5 years, 4 months ago by liberato (no reviews please)
Modified:
5 years, 4 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, mlamouri+watch-blink_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium, pangu
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable mute button, even if preferring hidden volume slider. Don't hide the mute button for anything with audio when using the new media playback UI. The old behavior is unchanged. Note that on clank, we don't really know if an audio track is present, so we always show the mute button. BUG=521789 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200908

Patch Set 1 #

Patch Set 2 : fixed test... which is why we have them. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -28 lines) Patch
M LayoutTests/media/video-controls-hidden-audio.html View 1 3 chunks +5 lines, -9 lines 0 comments Download
M LayoutTests/media/video-controls-hidden-audio-expected.txt View 1 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 5 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
liberato (no reviews please)
it turns out that the mute button is popular... so this brings it back for ...
5 years, 4 months ago (2015-08-20 06:29:23 UTC) #2
philipj_slow
lgtm
5 years, 4 months ago (2015-08-20 11:50:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303553003/20001
5 years, 4 months ago (2015-08-20 11:50:26 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 16:06:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200908

Powered by Google App Engine
This is Rietveld 408576698