LayoutTests/media/video-controls-hidden-audio-expected.txt - Issue 1303553003: Enable mute button, even if preferring hidden volume slider.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-controls-hidden-audio-expected.txt

Issue 1303553003: Enable mute button, even if preferring hidden volume slider. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fixed test... which is why we have them. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Test that hiding volume / mute buttons works as expected.	1 Test that hiding volume / mute buttons works as expected.

2	2

3 RUN(video.load())	3 RUN(video.load())

4 EVENT(canplaythrough)	4 EVENT(canplaythrough)

5 RUN(window.internals.setAllowHiddenVolumeControls(video, true))	5 RUN(window.internals.setAllowHiddenVolumeControls(video, true))

6 RUN(window.internals.settings.setPreferHiddenVolumeControls(false))	6 RUN(window.internals.settings.setPreferHiddenVolumeControls(false))

7 RUN(video.muted = false)	7 RUN(video.muted = false)

8 EXPECTED (getComputedStyle(muteButton).display != 'none') OK	8 EXPECTED (getComputedStyle(muteButton).display != 'none') OK

9 EXPECTED (getComputedStyle(volumeSlider).display != 'none') OK	9 EXPECTED (getComputedStyle(volumeSlider).display != 'none') OK

10 RUN(video.muted = true)	10 RUN(video.muted = true)

11 RUN(window.internals.setAllowHiddenVolumeControls(video, true))

12 EXPECTED (getComputedStyle(muteButton).display != 'none') OK	11 EXPECTED (getComputedStyle(muteButton).display != 'none') OK

13 EXPECTED (getComputedStyle(volumeSlider).display != 'none') OK	12 EXPECTED (getComputedStyle(volumeSlider).display != 'none') OK

14 RUN(window.internals.settings.setPreferHiddenVolumeControls(true))	13 RUN(window.internals.settings.setPreferHiddenVolumeControls(true))

15 RUN(video.muted = false)	14 RUN(video.muted = false)

16 RUN(window.internals.setAllowHiddenVolumeControls(video, true))	15 EXPECTED (getComputedStyle(muteButton).display != 'none') OK

17 EXPECTED (getComputedStyle(muteButton).display == 'none') OK

18 EXPECTED (getComputedStyle(volumeSlider).display == 'none') OK	16 EXPECTED (getComputedStyle(volumeSlider).display == 'none') OK

19 RUN(video.muted = true)	17 RUN(video.muted = true)

20 RUN(window.internals.setAllowHiddenVolumeControls(video, true))

21 EXPECTED (getComputedStyle(muteButton).display != 'none') OK	18 EXPECTED (getComputedStyle(muteButton).display != 'none') OK

22 EXPECTED (getComputedStyle(volumeSlider).display == 'none') OK	19 EXPECTED (getComputedStyle(volumeSlider).display == 'none') OK

23 END OF TEST	20 END OF TEST

24	21

OLD	NEW

« no previous file with comments | « LayoutTests/media/video-controls-hidden-audio.html ('k') | Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »