Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/media/video-controls-hidden-audio-expected.txt

Issue 1303553003: Enable mute button, even if preferring hidden volume slider. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixed test... which is why we have them. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/video-controls-hidden-audio.html ('k') | Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/media/video-controls-hidden-audio-expected.txt
diff --git a/LayoutTests/media/video-controls-hidden-audio-expected.txt b/LayoutTests/media/video-controls-hidden-audio-expected.txt
index 698c6a1371d2bb149c77152af7d70a083e8aaee5..53b2d955c09eaaeb88558456204691fdd1a758df 100644
--- a/LayoutTests/media/video-controls-hidden-audio-expected.txt
+++ b/LayoutTests/media/video-controls-hidden-audio-expected.txt
@@ -8,16 +8,13 @@ RUN(video.muted = false)
EXPECTED (getComputedStyle(muteButton).display != 'none') OK
EXPECTED (getComputedStyle(volumeSlider).display != 'none') OK
RUN(video.muted = true)
-RUN(window.internals.setAllowHiddenVolumeControls(video, true))
EXPECTED (getComputedStyle(muteButton).display != 'none') OK
EXPECTED (getComputedStyle(volumeSlider).display != 'none') OK
RUN(window.internals.settings.setPreferHiddenVolumeControls(true))
RUN(video.muted = false)
-RUN(window.internals.setAllowHiddenVolumeControls(video, true))
-EXPECTED (getComputedStyle(muteButton).display == 'none') OK
+EXPECTED (getComputedStyle(muteButton).display != 'none') OK
EXPECTED (getComputedStyle(volumeSlider).display == 'none') OK
RUN(video.muted = true)
-RUN(window.internals.setAllowHiddenVolumeControls(video, true))
EXPECTED (getComputedStyle(muteButton).display != 'none') OK
EXPECTED (getComputedStyle(volumeSlider).display == 'none') OK
END OF TEST
« no previous file with comments | « LayoutTests/media/video-controls-hidden-audio.html ('k') | Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698