Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Issue 1303463002: Remove inline header includes from natives.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
titzer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove inline header includes from natives.h header. R=yangguo@chromium.org Committed: https://crrev.com/366262e60658967e29afb260ae01c9815f81a4ea Cr-Commit-Position: refs/heads/master@{#30222}

Patch Set 1 #

Patch Set 2 : Add missing file. #

Patch Set 3 : Fix Windows part 1. #

Patch Set 4 : Fix Windows part 2. #

Total comments: 2

Patch Set 5 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -45 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/snapshot/natives.h View 3 chunks +2 lines, -39 lines 0 comments Download
A src/snapshot/natives-common.cc View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
M src/snapshot/natives-external.cc View 1 2 3 1 chunk +14 lines, -6 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-18 12:05:29 UTC) #1
Yang
On 2015/08/18 12:05:29, Michael Starzinger wrote: lgtm if buildbots agree!
5 years, 4 months ago (2015-08-18 12:38:12 UTC) #2
titzer
https://codereview.chromium.org/1303463002/diff/60001/src/snapshot/natives-common.cc File src/snapshot/natives-common.cc (right): https://codereview.chromium.org/1303463002/diff/60001/src/snapshot/natives-common.cc#newcode15 src/snapshot/natives-common.cc:15: FixedArray* Natives::GetSourceCache(Heap* heap) { Can we have the explicit ...
5 years, 4 months ago (2015-08-18 12:42:44 UTC) #4
Michael Starzinger
https://codereview.chromium.org/1303463002/diff/60001/src/snapshot/natives-common.cc File src/snapshot/natives-common.cc (right): https://codereview.chromium.org/1303463002/diff/60001/src/snapshot/natives-common.cc#newcode15 src/snapshot/natives-common.cc:15: FixedArray* Natives::GetSourceCache(Heap* heap) { On 2015/08/18 12:42:44, titzer wrote: ...
5 years, 4 months ago (2015-08-18 12:45:54 UTC) #5
titzer
lgtm
5 years, 4 months ago (2015-08-18 12:53:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303463002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303463002/80001
5 years, 4 months ago (2015-08-18 14:30:21 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-18 14:31:32 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 14:31:42 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/366262e60658967e29afb260ae01c9815f81a4ea
Cr-Commit-Position: refs/heads/master@{#30222}

Powered by Google App Engine
This is Rietveld 408576698