BUILD.gn - Issue 1303463002: Remove inline header includes from natives.h header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 1303463002: Remove inline header includes from natives.h header. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 59314f2d5f99ff6f3f62510108aaa47a93ddcc18..c2b4462cfbb9a4c411c01167a9ab575bbbcc8136 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -1135,6 +1135,7 @@ source_set("v8_base") {

"src/simulator.h",

"src/small-pointer-list.h",

"src/snapshot/natives.h",

+ "src/snapshot/natives-common.cc",

"src/snapshot/serialize.cc",

"src/snapshot/serialize.h",

"src/snapshot/snapshot-common.cc",

« no previous file with comments | « no previous file | src/snapshot/natives.h » ('j') | no next file with comments »