Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: src/snapshot/natives.h

Issue 1303463002: Remove inline header includes from natives.h header. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/snapshot/natives-common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/natives.h
diff --git a/src/snapshot/natives.h b/src/snapshot/natives.h
index 8c24bd23d089d6abd2bf9290487ec0e12f7c37a2..1efaf7ece5da4b7bba5c368c33252f58f7f75c16 100644
--- a/src/snapshot/natives.h
+++ b/src/snapshot/natives.h
@@ -5,10 +5,7 @@
#ifndef V8_SNAPSHOT_NATIVES_H_
#define V8_SNAPSHOT_NATIVES_H_
-#include "src/heap/heap.h"
-#include "src/heap/heap-inl.h"
#include "src/objects.h"
-#include "src/objects-inl.h"
#include "src/vector.h"
namespace v8 { class StartupData; } // Forward declaration.
@@ -37,9 +34,9 @@ class NativesCollection {
static Vector<const char> GetScriptName(int index);
static Vector<const char> GetScriptsSource();
- // The following methods are implemented below:
+ // The following methods are implemented in natives-common.cc:
- inline static FixedArray* GetSourceCache(Heap* heap);
+ static FixedArray* GetSourceCache(Heap* heap);
static void UpdateSourceCache(Heap* heap);
};
@@ -49,40 +46,6 @@ typedef NativesCollection<EXPERIMENTAL> ExperimentalNatives;
typedef NativesCollection<EXTRAS> ExtraNatives;
-template <>
-inline FixedArray* Natives::GetSourceCache(Heap* heap) {
- return heap->natives_source_cache();
-}
-
-
-template <>
-inline FixedArray* ExperimentalNatives::GetSourceCache(Heap* heap) {
- return heap->experimental_natives_source_cache();
-}
-
-
-template <>
-inline FixedArray* ExtraNatives::GetSourceCache(Heap* heap) {
- return heap->extra_natives_source_cache();
-}
-
-
-template <>
-inline FixedArray* CodeStubNatives::GetSourceCache(Heap* heap) {
- return heap->code_stub_natives_source_cache();
-}
-
-template <NativeType type>
-void NativesCollection<type>::UpdateSourceCache(Heap* heap) {
- for (int i = 0; i < GetBuiltinsCount(); i++) {
- Object* source = GetSourceCache(heap)->get(i);
- if (!source->IsUndefined()) {
- ExternalOneByteString::cast(source)->update_data_cache();
- }
- }
-}
-
-
#ifdef V8_USE_EXTERNAL_STARTUP_DATA
// Used for reading the natives at runtime. Implementation in natives-empty.cc
void SetNativesFromFile(StartupData* natives_blob);
« no previous file with comments | « BUILD.gn ('k') | src/snapshot/natives-common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698