Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1302463002: Make classes and structures in Source/core/animation fast-allocated. (Closed)

Created:
5 years, 4 months ago by tasak
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, shans, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in Source/core/animation fast-allocated. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200804

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M Source/core/animation/Animation.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationClock.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationEffect.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationInputHelpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationTimeline.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/CompositorAnimations.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/animation/CompositorAnimationsImpl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/animation/DocumentAnimation.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/EffectInput.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/ElementAnimation.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/ElementAnimations.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/InterpolableValue.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/Interpolation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/InterpolationType.h View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/animation/Keyframe.h View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/animation/LengthPropertyFunctions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/LengthSVGInterpolation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/PointSVGInterpolation.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/PrimitiveInterpolation.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/animation/PropertyHandle.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/animation/SampledEffect.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/animation/Timing.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/animation/TimingInput.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/TransformSVGInterpolation.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/animatable/AnimatableColor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimationUpdate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSPropertyEquality.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSTimingData.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSTransitionData.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1278983003 Patch 40001

Messages

Total messages: 9 (5 generated)
tasak
Would you review this CL?
5 years, 4 months ago (2015-08-19 04:47:23 UTC) #5
haraken
LGTM I'm surprised that these heavily-allocated animation objects are not yet on PartitionAlloc. This CL ...
5 years, 4 months ago (2015-08-19 04:53:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302463002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302463002/120001
5 years, 4 months ago (2015-08-19 04:56:02 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 06:42:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200804

Powered by Google App Engine
This is Rietveld 408576698