[Mac] Remove kPulseBookmarkButtonNotification.

[Mac] Remove kPulseBookmarkButtonNotification.

This is only used by BookmarkBubbleController to inform
BookmarkBarController to pulse a button in the bar. Change this to a
direct call instead of via the notification system.

Closed in favor of: https://codereview.chromium.org/1308293002/

BUG=None

[jackhou1, 2015-08-21 07:24:29]

jackhou@chromium.org changed reviewers:
+ asvitkine@chromium.org

[jackhou1, 2015-08-21 07:24:30]

asvitkine, could you take a look?

[jackhou1, 2015-08-24 08:34:49]

On 2015/08/21 07:24:30, jackhou1 wrote:
> asvitkine, could you take a look?

Please hold off on reviewing this CL. I think it'll be better as part of a
larger refactor: https://codereview.chromium.org/1308293002/
(Apologies if you've already started reviewing).

[jackhou1, 2015-08-24 08:35:02]

jackhou@chromium.org changed reviewers:
- asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-08-24 14:43:40]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-08-24 14:43:41]

Looks good overall, could you add a crbug since the change is non-trivial?

https://codereview.chromium.org/1302243002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right):

https://codereview.chromium.org/1302243002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:106:
browserWindowControllerForWindow:self.parentWindow] bookmarkBarController]
Nit: Can you make a helper for getting the bookmark bar controller? This way
this and line 115 can be more readable.

[Alexei Svitkine (slow), 2015-08-24 14:48:24]

Oops, sorry didn't see your second message.

On Mon, Aug 24, 2015 at 10:43 AM, <asvitkine@chromium.org> wrote:

> Looks good overall, could you add a crbug since the change is non-trivial?
>
>
>
>
https://codereview.chromium.org/1302243002/diff/20001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
> (right):
>
>
>
https://codereview.chromium.org/1302243002/diff/20001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:106:
> browserWindowControllerForWindow:self.parentWindow]
> bookmarkBarController]
> Nit: Can you make a helper for getting the bookmark bar controller? This
> way this and line 115 can be more readable.
>
> https://codereview.chromium.org/1302243002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.