[Mac] Remove kPulseBookmarkButtonNotification.

chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 83 matching lines @@
     // Adjust the height of the bubble so that the sync promo fits in it,
     // except for its bottom border. The xib file hides the left and right
     // borders of the sync promo.
     NSRect bubbleFrame = [[self window] frame];
     bubbleFrame.size.height +=
         syncPromoHeight - [syncPromoController_ borderWidth];
     [[self window] setFrame:bubbleFrame display:YES];
   }
 }
 
-// If this is a new bookmark somewhere visible (e.g. on the bookmark
-// bar), pulse it.  Else, call ourself recursively with our parent
-// until we find something visible to pulse.
 - (void)startPulsingBookmarkButton:(const BookmarkNode*)node  {
-  while (node) {
-    if ((node->parent() == model_->bookmark_bar_node()) ||
-        (node->parent() ==
-         managedBookmarkService_->managed_node()) ||
-        (node->parent() == managedBookmarkService_->supervised_node()) ||
-        (node == model_->other_node())) {
-      pulsingBookmarkNode_ = node;
-      bookmarkObserver_->StartObservingNode(pulsingBookmarkNode_);
-      NSValue *value = [NSValue valueWithPointer:node];
-      NSDictionary *dict = [NSDictionary
-                             dictionaryWithObjectsAndKeys:value,
-                             bookmark_button::kBookmarkKey,
-                             [NSNumber numberWithBool:YES],
-                             bookmark_button::kBookmarkPulseFlagKey,
-                             nil];
-      [[NSNotificationCenter defaultCenter]
-        postNotificationName:bookmark_button::kPulseBookmarkButtonNotification
-                      object:self
-                    userInfo:dict];
-      return;
-    }
-    node = node->parent();
-  }
+  pulsingBookmarkNode_ = [[[BrowserWindowController
+      browserWindowControllerForWindow:self.parentWindow] bookmarkBarController]

[Alexei Svitkine (slow), 2015/08/24 14:43:41]

Nit: Can you make a helper for getting the bookmark bar controller? This way
this and line 115 can be more readable.

+      startPulsingBookmarkNode:node];
+  bookmarkObserver_->StartObservingNode(pulsingBookmarkNode_);
 }
 
 - (void)stopPulsingBookmarkButton {
   if (!pulsingBookmarkNode_)
     return;
-  NSValue *value = [NSValue valueWithPointer:pulsingBookmarkNode_];
-  if (bookmarkObserver_)
-      bookmarkObserver_->StopObservingNode(pulsingBookmarkNode_);
-  pulsingBookmarkNode_ = NULL;
-  NSDictionary *dict = [NSDictionary
-                         dictionaryWithObjectsAndKeys:value,
-                         bookmark_button::kBookmarkKey,
-                         [NSNumber numberWithBool:NO],
-                         bookmark_button::kBookmarkPulseFlagKey,
-                         nil];
-  [[NSNotificationCenter defaultCenter]
-        postNotificationName:bookmark_button::kPulseBookmarkButtonNotification
-                      object:self
-                    userInfo:dict];
+
+  [[[BrowserWindowController browserWindowControllerForWindow:self.parentWindow]
+      bookmarkBarController] stopPulsingBookmarkNode:pulsingBookmarkNode_];
+  pulsingBookmarkNode_ = nullptr;
 }
 
 // Close the bookmark bubble without changing anything.  Unlike a
 // typical dialog's OK/Cancel, where Cancel is "do nothing", all
 // buttons on the bubble have the capacity to change the bookmark
 // model.  This is an IBOutlet-looking entry point to remove the
 // dialog without touching the model.
 - (void)dismissWithoutEditing:(id)sender {
   [self close];
 }
@@ skipping 191 matching lines @@
 
 @end  // BookmarkBubbleController
 
 
 @implementation BookmarkBubbleController (ExposedForUnitTesting)
 
 - (NSView*)syncPromoPlaceholder {
   return syncPromoPlaceholder_;
 }
 
+- (const BookmarkNode*)pulsingBookmarkNode {
+  return pulsingBookmarkNode_;
+}
+
 + (NSString*)chooseAnotherFolderString {
   return l10n_util::GetNSStringWithFixup(
       IDS_BOOKMARK_BUBBLE_CHOOSER_ANOTHER_FOLDER);
 }
 
 // For the given folder node, walk the tree and add folder names to
 // the given pop up button.
 - (void)addFolderNodes:(const BookmarkNode*)parent
          toPopUpButton:(NSPopUpButton*)button
            indentation:(int)indentation {
@@ skipping 33 matching lines @@
   NSInteger idx = [menu indexOfItemWithRepresentedObject:parentValue];
   DCHECK(idx != -1);
   [folderPopUpButton_ selectItemAtIndex:idx];
 }
 
 - (NSPopUpButton*)folderPopUpButton {
   return folderPopUpButton_;
 }
 
 @end  // implementation BookmarkBubbleController(ExposedForUnitTesting)