[Mac] Enable MacViews bookmark editor behind --enable-mac-views-dialogs.

[Mac] Enable MacViews bookmark editor behind --enable-mac-views-dialogs.

This allows the Views bookmark editor dialog to be used on Cocoa builds.

In constrained_window::CreateBrowserModalDialogViews, don't create a
WidgetModalDialogHostObserverViews since the dialog position is
automatically managed by NSWindow.

Estimated framework size increase (based at r343839):
Before: 108,212,720
After: 108,241,624
Delta: 28,904 (0.03%)

BUG=511051
Committed: https://crrev.com/b42a1f3d9cfc20a9f35db41477bfaa0abf0ed063
Cr-Commit-Position: refs/heads/master@{#345027}

[jackhou1, 2015-08-21 01:19:00]

jackhou@chromium.org changed reviewers:
+ tapted@chromium.org

[jackhou1, 2015-08-21 01:19:01]

tapted, PTAL

Split out from https://codereview.chromium.org/1307533002/

> components/constrained_window/constrained_window_views.cc:173: return widget;
> I know the compiler allows it.. but there's something weird about making the
> code below unreachable on mac. Perhaps
> 
> #if defined(OS_MACOSX)
>   bool requires_positioning = false;
> #else
>   bool requires_positioning = dialog->UseNewStyleForThisDialog();
> #endif
> 
> if (!requires_positioning)
>   return widget;
> 
> But also this will affect the mac_views_browser build, where the code here
> currently works OK (I think..). Is mac_views_browser still OK with this
change?
> What breaks without it? Maybe there's an alternative..

The existing code does work on mac_views_browser, but is redundant since it's
still a sheet.

It breaks in the DCHECK_EQ(parent_view, host->GetHostView()) below because one
is the contentView and the other is the WebContents. It also breaks in
UpdateModalDialogPosition above because it assumes the parent is a Widget. We
could fix these, but they're not necessary on Mac anyway.

[tapted, 2015-08-21 01:22:49]

lgtm

https://codereview.chromium.org/1309583002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/1309583002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:107: void
ShowBookmarkEditorView(gfx::NativeWindow parent_window,
nit: View -> Views

[jackhou1, 2015-08-21 02:27:32]

https://codereview.chromium.org/1309583002/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/1309583002/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_dialogs.h:107: void
ShowBookmarkEditorView(gfx::NativeWindow parent_window,
On 2015/08/21 01:22:49, tapted wrote:
> nit: View -> Views

Done.

[jackhou1, 2015-08-21 02:28:58]

jackhou@chromium.org changed reviewers:
+ msw@chromium.org

[jackhou1, 2015-08-21 02:28:59]

msw, please review for OWNERS

[msw, 2015-08-21 18:47:02]

lgtm with nits.

https://codereview.chromium.org/1309583002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/browser_dialogs_views.cc (right):

https://codereview.chromium.org/1309583002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/browser_dialogs_views.cc:7: #include
"chrome/browser/ui/login/login_prompt.h"
optional nit: move this include to chrome/browser/ui/browser_dialogs.h?

https://codereview.chromium.org/1309583002/diff/40001/components/constrained_...
File components/constrained_window/constrained_window_views.cc (right):

https://codereview.chromium.org/1309583002/diff/40001/components/constrained_...
components/constrained_window/constrained_window_views.cc:175: bool
requires_positioning = dialog->UseNewStyleForThisDialog();
nit: decl/init this above the #ifdef block, and just force it false for Mac.

[jackhou1, 2015-08-24 01:41:55]

https://codereview.chromium.org/1309583002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/browser_dialogs_views.cc (right):

https://codereview.chromium.org/1309583002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/browser_dialogs_views.cc:7: #include
"chrome/browser/ui/login/login_prompt.h"
On 2015/08/21 18:47:02, msw wrote:
> optional nit: move this include to chrome/browser/ui/browser_dialogs.h?

bookmark_editor.h had to be included in browser_dialogs.h because
BookmarkEditor::Configuration is passed by value. LoginHandler can still be
forward declared in browser_dialogs.h, so I think it's better to leave this
here.

https://codereview.chromium.org/1309583002/diff/40001/components/constrained_...
File components/constrained_window/constrained_window_views.cc (right):

https://codereview.chromium.org/1309583002/diff/40001/components/constrained_...
components/constrained_window/constrained_window_views.cc:175: bool
requires_positioning = dialog->UseNewStyleForThisDialog();
On 2015/08/21 18:47:02, msw wrote:
> nit: decl/init this above the #ifdef block, and just force it false for Mac.

Done.

[jackhou1, 2015-08-24 05:14:51]

The CQ bit was checked by jackhou@chromium.org

[jackhou1, 2015-08-24 05:14:51]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org,
msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1309583002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2015-08-24 05:14:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1309583002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1309583002/60001

[commit-bot: I haz the power, 2015-08-24 05:53:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-24 05:54:27]

Patchset 4 (id:??) landed as
https://crrev.com/b42a1f3d9cfc20a9f35db41477bfaa0abf0ed063
Cr-Commit-Position: refs/heads/master@{#345027}