Switch security handler to use "neutral" security state instead of "http". (3/4)

Switch security handler to use "neutral" security state instead of "http".

BUG=522274
Committed: https://crrev.com/218cb599d39c5341a7659f53f37f5091293f4507
Cr-Commit-Position: refs/heads/master@{#344166}

[lgarron, 2015-08-18 22:31:41]

lgarron@chromium.org changed reviewers:
+ pfeldman@chromium.org

[lgarron, 2015-08-18 22:31:42]

Pavel, would you mind reviewing this multi-step patch? (This is #3.)

1. https://codereview.chromium.org/1301823003 Add neutral as a SecurityState in
the Security domain. (Blink)
2. https://codereview.chromium.org/1289203009 Switch InspectorResourceAgent to
use Neutral instead of Http for SecurityState. (Blink)
3. https://codereview.chromium.org/1301833002 Switch security handler to use
"neutral" security state instead of "http". (Chrome)
4. https://codereview.chromium.org/1291543005
https://codereview.chromium.org/1291543005 (Blink)

(#2 and #3 can be done in parallel.)

[pfeldman, 2015-08-18 23:48:52]

https://codereview.chromium.org/1301833002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/security_handler.cc (right):

https://codereview.chromium.org/1301833002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/security_handler.cc:36: NOTREACHED();
Remove this so that you don't have to do complex two-sided patches.

[pfeldman, 2015-08-18 23:49:31]

lgtm

[lgarron, 2015-08-19 04:00:15]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-08-19 04:00:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301833002/1

[commit-bot: I haz the power, 2015-08-19 04:08:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 04:08:44]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lgarron, 2015-08-19 05:28:11]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-08-19 05:28:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301833002/1

[lgarron, 2015-08-19 06:17:30]

https://codereview.chromium.org/1301833002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/security_handler.cc (right):

https://codereview.chromium.org/1301833002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/security_handler.cc:36: NOTREACHED();
On 2015/08/18 at 23:48:52, pfeldman wrote:
> Remove this so that you don't have to do complex two-sided patches.

This patch actually isn't affected by the NOTREACHED, because it's a change in
the protocol.json enum (i.e. the return type of this function).

[commit-bot: I haz the power, 2015-08-19 06:48:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-19 06:49:47]

Patchset 1 (id:??) landed as
https://crrev.com/218cb599d39c5341a7659f53f37f5091293f4507
Cr-Commit-Position: refs/heads/master@{#344166}