Switch security handler to use "neutral" security state instead of "http". (3/4)

content/browser/devtools/protocol/security_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/protocol/security_handler.h"
 
 #include <string>
 
 #include "content/browser/devtools/protocol/devtools_protocol_dispatcher.h"
 #include "content/public/browser/security_style_explanations.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_delegate.h"
 
 namespace content {
 namespace devtools {
 namespace security {
 
 typedef DevToolsProtocolClient::Response Response;
 
 namespace {
 
 std::string SecurityStyleToProtocolSecurityState(
     SecurityStyle security_style) {
   switch (security_style) {
     case SECURITY_STYLE_UNKNOWN:
       return kSecurityStateUnknown;
     case SECURITY_STYLE_UNAUTHENTICATED:
-      return kSecurityStateHttp;
+      return kSecurityStateNeutral;
     case SECURITY_STYLE_AUTHENTICATION_BROKEN:
       return kSecurityStateInsecure;
     case SECURITY_STYLE_WARNING:
       return kSecurityStateWarning;
     case SECURITY_STYLE_AUTHENTICATED:
       return kSecurityStateSecure;
     default:
       NOTREACHED();

[pfeldman, 2015/08/18 23:48:52]

Remove this so that you don't have to do complex two-sided patches.

[lgarron, 2015/08/19 06:17:30]

This patch actually isn't affected by the NOTREACHED, because it's a change in
the protocol.json enum (i.e. the return type of this function).

       return kSecurityStateUnknown;
   }
 }
 
 void AddExplanations(
     const std::string& security_style,
     const std::vector<SecurityStyleExplanation>& explanations_to_add,
     std::vector<scoped_refptr<SecurityStateExplanation>>* explanations) {
   for (const auto& it : explanations_to_add) {
     explanations->push_back(SecurityStateExplanation::Create()
@@ skipping 88 matching lines @@
 
 Response SecurityHandler::Disable() {
   enabled_ = false;
   WebContentsObserver::Observe(nullptr);
   return Response::OK();
 }
 
 }  // namespace security
 }  // namespace devtools
 }  // namespace content