Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: trunk/src/chrome/browser/password_manager/password_manager_unittest.cc

Issue 130183003: Revert 248117 "Password manager now ignores autocomplete='off' b..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/password_manager/password_manager_unittest.cc
===================================================================
--- trunk/src/chrome/browser/password_manager/password_manager_unittest.cc (revision 248129)
+++ trunk/src/chrome/browser/password_manager/password_manager_unittest.cc (working copy)
@@ -504,8 +504,8 @@
manager()->OnPasswordFormsParsed(observed);
}
-TEST_F(PasswordManagerTest, FormSavedWithAutocompleteOff) {
- // Test password form with non-generated password will be saved even if
+TEST_F(PasswordManagerTest, FormNotSavedAutocompleteOff) {
+ // Test password form with non-generated password will not be saved if
// autocomplete=off.
std::vector<PasswordForm*> result; // Empty password store.
EXPECT_CALL(delegate_, FillPasswordForm(_)).Times(Exactly(0));
@@ -521,9 +521,9 @@
// And the form submit contract is to call ProvisionallySavePassword.
manager()->ProvisionallySavePassword(form);
- // Password form should be saved.
+ // Password form should not be saved.
EXPECT_CALL(delegate_,
- AddSavePasswordInfoBarIfPermitted(_)).Times(Exactly(1));
+ AddSavePasswordInfoBarIfPermitted(_)).Times(Exactly(0));
EXPECT_CALL(*store_.get(), AddLogin(FormMatches(form))).Times(Exactly(0));
// Now the password manager waits for the navigation to complete.

Powered by Google App Engine
This is Rietveld 408576698