Setup for moving getUserMedia to secure origins only

Setup for moving getUserMedia to secure origins only

This makes two notable changes:
  * Removes the browser tests that verify that the getUserMedia
    permission is not "sticky" on insecure origins.
  * Moves the addition of the chrome-extension: and
    chrome-extension-resource: schemes to extensions::Dispatcher.

The former is necessary because once getUserMedia is removed from
insecure origins, the browser test will (correctly) fail. Thus this is
part of a two sided patch.

The later is necessary because extension browser tests that use
getUserMedia will start failing once the change is made, because the
tests use ShellContentRendererClient, which doesn't currently treat
chrome-extension: schemes as secure, so getUserMedia will be disallowed
by the renderer. By marking the scheme as secure in
extensions::Dispatcher instead of in
ChromeContentRendererClient::RenderThreadStarted, the schemes will be
marked as secure in ShellContentRendererClient as well, so getUserMedia
will be allowed in the browser tests.

BUG=520765
Committed: https://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f
Cr-Commit-Position: refs/heads/master@{#344635}

[jww, 2015-08-20 16:30:01]

jww@chromium.org changed reviewers:
+ ddorwin@chromium.org, rdevlin.cronin@chromium.org

[jww, 2015-08-20 16:30:02]

rdevlin.cronin@chromium.org: Please review changes in
extensions/shell/renderer/shell_content_renderer_client.cc

ddorwin@chromium.org: Please review changes in
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc

For reference, here is the actual patch to remove getUserMedia on insecure
origins: https://codereview.chromium.org/1284193003/

Thanks!

[Devlin, 2015-08-20 16:37:20]

extensions lgtm with a suggestion.

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
extensions/shell/renderer/shell_content_renderer_client.cc:66: //
chrome-extensions: and chrome-extensions-resource: schemes should be
If you wanted to be *really* cool, you could put these into
extensions::Dispatcher::Dispatcher(), and take them out of
ChromeContentRendererClient (the dispatcher is created for both shell and chrome
renderers already).  Less code, less duplicate code, better layering, all that
jazz.

[jww, 2015-08-20 16:50:35]

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
extensions/shell/renderer/shell_content_renderer_client.cc:66: //
chrome-extensions: and chrome-extensions-resource: schemes should be
On 2015/08/20 16:37:20, Devlin wrote:
> If you wanted to be *really* cool, you could put these into
> extensions::Dispatcher::Dispatcher(), and take them out of
> ChromeContentRendererClient (the dispatcher is created for both shell and
chrome
> renderers already).  Less code, less duplicate code, better layering, all that
> jazz.

Done.

[ddorwin, 2015-08-20 16:56:11]

LGTM. +tommi FYI

[ddorwin, 2015-08-20 16:57:20]

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
extensions/shell/renderer/shell_content_renderer_client.cc:66: //
chrome-extensions: and chrome-extensions-resource: schemes should be
On 2015/08/20 16:50:35, jww wrote:
> On 2015/08/20 16:37:20, Devlin wrote:
> > If you wanted to be *really* cool, you could put these into
> > extensions::Dispatcher::Dispatcher(), and take them out of
> > ChromeContentRendererClient (the dispatcher is created for both shell and
> chrome
> > renderers already).  Less code, less duplicate code, better layering, all
that
> > jazz.
> 
> Done.

It doesn't look like you uploaded this. I'm not sure if that was intentional.

[tommi (sloooow) - chröme, 2015-08-20 17:14:24]

tommi@chromium.org changed reviewers:
+ tommi@chromium.org

[tommi (sloooow) - chröme, 2015-08-20 17:14:25]

https://codereview.chromium.org/1301653005/diff/1/chrome/browser/media/chrome...
File chrome/browser/media/chrome_media_stream_infobar_browsertest.cc (left):

https://codereview.chromium.org/1301653005/diff/1/chrome/browser/media/chrome...
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc:73:
use_secure_origin_for_test_page_ = false;
looks like this variable isn't needed anymore and related code needs to be
updated.

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
extensions/shell/renderer/shell_content_renderer_client.cc:67: // treated as
secure.
can you extend this comment to explain why?  I think the code explains itself
but understanding why would be good.

[jww, 2015-08-20 18:26:06]

jww@chromium.org changed reviewers:
+ thestig@chromium.org

[jww, 2015-08-20 18:26:07]

thestig@chromium.org, can you take a look at
chrome/renderer/chrome_content_renderer_client.cc? Note that this just moves the
code in that file to extensions/renderer/dispatcher.cc.

https://codereview.chromium.org/1301653005/diff/1/chrome/browser/media/chrome...
File chrome/browser/media/chrome_media_stream_infobar_browsertest.cc (left):

https://codereview.chromium.org/1301653005/diff/1/chrome/browser/media/chrome...
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc:73:
use_secure_origin_for_test_page_ = false;
On 2015/08/20 17:14:25, tommi wrote:
> looks like this variable isn't needed anymore and related code needs to be
> updated.

Good call. Done.

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
extensions/shell/renderer/shell_content_renderer_client.cc:66: //
chrome-extensions: and chrome-extensions-resource: schemes should be
On 2015/08/20 16:57:20, ddorwin wrote:
> On 2015/08/20 16:50:35, jww wrote:
> > On 2015/08/20 16:37:20, Devlin wrote:
> > > If you wanted to be *really* cool, you could put these into
> > > extensions::Dispatcher::Dispatcher(), and take them out of
> > > ChromeContentRendererClient (the dispatcher is created for both shell and
> > chrome
> > > renderers already).  Less code, less duplicate code, better layering, all
> that
> > > jazz.
> > 
> > Done.
> 
> It doesn't look like you uploaded this. I'm not sure if that was intentional.

My mistake. Done.

https://codereview.chromium.org/1301653005/diff/1/extensions/shell/renderer/s...
extensions/shell/renderer/shell_content_renderer_client.cc:67: // treated as
secure.
On 2015/08/20 17:14:25, tommi wrote:
> can you extend this comment to explain why?  I think the code explains itself
> but understanding why would be good.

Done.

[Devlin, 2015-08-20 18:29:34]

(extensions still lgtm)

https://codereview.chromium.org/1301653005/diff/40001/chrome/renderer/chrome_...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/40001/chrome/renderer/chrome_...
chrome/renderer/chrome_content_renderer_client.cc:502: // care of in
extension::Dispatcher.
nitty nit: extensions::, not extension::

https://codereview.chromium.org/1301653005/diff/40001/extensions/shell/render...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/40001/extensions/shell/render...
extensions/shell/renderer/shell_content_renderer_client.cc:25: #include
"third_party/WebKit/public/web/WebSecurityPolicy.h"
don't need this includes now.

[tommi (sloooow) - chröme, 2015-08-20 18:36:53]

Thanks! lgtm.

[Lei Zhang, 2015-08-20 20:43:01]

lgtm

[jww, 2015-08-20 22:59:03]

lgarron@, FYI

https://codereview.chromium.org/1301653005/diff/40001/chrome/renderer/chrome_...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/40001/chrome/renderer/chrome_...
chrome/renderer/chrome_content_renderer_client.cc:502: // care of in
extension::Dispatcher.
On 2015/08/20 18:29:34, Devlin wrote:
> nitty nit: extensions::, not extension::

Done.

https://codereview.chromium.org/1301653005/diff/40001/extensions/shell/render...
File extensions/shell/renderer/shell_content_renderer_client.cc (right):

https://codereview.chromium.org/1301653005/diff/40001/extensions/shell/render...
extensions/shell/renderer/shell_content_renderer_client.cc:25: #include
"third_party/WebKit/public/web/WebSecurityPolicy.h"
On 2015/08/20 18:29:34, Devlin wrote:
> don't need this includes now.

Done.

[jww, 2015-08-20 22:59:09]

The CQ bit was checked by jww@chromium.org

[jww, 2015-08-20 22:59:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
ddorwin@chromium.org, thestig@chromium.org, rdevlin.cronin@chromium.org,
tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1301653005/#ps60001
(title: "Nits")

[jww, 2015-08-20 22:59:30]

The CQ bit was unchecked by jww@chromium.org

[jww, 2015-08-20 23:02:45]

The CQ bit was checked by jww@chromium.org

[commit-bot: I haz the power, 2015-08-20 23:04:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301653005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301653005/60001

[commit-bot: I haz the power, 2015-08-21 01:05:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-21 01:06:29]

Patchset 4 (id:??) landed as
https://crrev.com/8440052c7882f61cfde793f687e72717c85e0d8f
Cr-Commit-Position: refs/heads/master@{#344635}