Setup for moving getUserMedia to secure origins only

extensions/shell/renderer/shell_content_renderer_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/shell/renderer/shell_content_renderer_client.h"
 
+#include "base/strings/utf_string_conversions.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_frame_observer.h"
 #include "content/public/renderer/render_frame_observer_tracker.h"
 #include "content/public/renderer/render_thread.h"
+#include "extensions/common/constants.h"
 #include "extensions/common/extensions_client.h"
 #include "extensions/renderer/dispatcher.h"
 #include "extensions/renderer/dispatcher_delegate.h"
 #include "extensions/renderer/extension_frame_helper.h"
 #include "extensions/renderer/extension_helper.h"
 #include "extensions/renderer/guest_view/extensions_guest_view_container.h"
 #include "extensions/renderer/guest_view/extensions_guest_view_container_dispatcher.h"
 #include "extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h"
 #include "extensions/shell/common/shell_extensions_client.h"
 #include "extensions/shell/renderer/shell_extensions_renderer_client.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
+#include "third_party/WebKit/public/web/WebSecurityPolicy.h"
 
 #if !defined(DISABLE_NACL)
 #include "components/nacl/common/nacl_constants.h"
 #include "components/nacl/renderer/nacl_helper.h"
 #include "components/nacl/renderer/ppb_nacl_private.h"
 #include "components/nacl/renderer/ppb_nacl_private_impl.h"
 #endif
 
 using blink::WebFrame;
 using blink::WebString;
@@ skipping 20 matching lines @@
 
   // Must be initialized after ExtensionsRendererClient.
   extension_dispatcher_.reset(
       new Dispatcher(extension_dispatcher_delegate_.get()));
   thread->AddObserver(extension_dispatcher_.get());
 
   guest_view_container_dispatcher_.reset(
       new ExtensionsGuestViewContainerDispatcher());
   thread->AddObserver(guest_view_container_dispatcher_.get());
 
-  // TODO(jamescook): Init WebSecurityPolicy for chrome-extension: schemes.
-  // See ChromeContentRendererClient for details.
+  // chrome-extensions: and chrome-extensions-resource: schemes should be

[Devlin, 2015/08/20 16:37:20]

If you wanted to be *really* cool, you could put these into
extensions::Dispatcher::Dispatcher(), and take them out of
ChromeContentRendererClient (the dispatcher is created for both shell and chrome
renderers already).  Less code, less duplicate code, better layering, all that
jazz.

[jww, 2015/08/20 16:50:35]

Done.

[ddorwin, 2015/08/20 16:57:20]

It doesn't look like you uploaded this. I'm not sure if that was intentional.

[jww, 2015/08/20 18:26:07]

My mistake. Done.

+  // treated as secure.

[tommi (sloooow) - chröme, 2015/08/20 17:14:25]

can you extend this comment to explain why?  I think the code explains itself
but understanding why would be good.

[jww, 2015/08/20 18:26:07]

Done.

+  WebString extension_scheme(base::ASCIIToUTF16(kExtensionScheme));
+  blink::WebSecurityPolicy::registerURLSchemeAsSecure(extension_scheme);
+
+  WebString extension_resource_scheme(base::ASCIIToUTF16(
+      kExtensionResourceScheme));
+  blink::WebSecurityPolicy::registerURLSchemeAsSecure(
+      extension_resource_scheme);
 }
 
 void ShellContentRendererClient::RenderFrameCreated(
     content::RenderFrame* render_frame) {
   // ExtensionFrameHelper destroys itself when the RenderFrame is destroyed.
   new ExtensionFrameHelper(render_frame, extension_dispatcher_.get());
   extension_dispatcher_->OnRenderFrameCreated(render_frame);
 
   // TODO(jamescook): Do we need to add a new PepperHelper(render_frame) here?
   // It doesn't seem necessary for either Pepper or NaCl.
@@ skipping 70 matching lines @@
     return new extensions::MimeHandlerViewContainer(
         render_frame, mime_type, original_url);
   }
 }
 
 ExtensionsClient* ShellContentRendererClient::CreateExtensionsClient() {
   return new ShellExtensionsClient;
 }
 
 }  // namespace extensions