Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1301583004: Revert of Delete dead signin code (SigninGlobalError) (Closed)

Created:
5 years, 4 months ago by Adam Rice
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delete dead signin code (SigninGlobalError) (patchset #8 id:140001 of https://codereview.chromium.org/1299543002/ ) Reason for revert: Broke the Mac10.9 Tests (dbg) bot: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/10278 See the stack trace in the logs. Original issue's description: > Delete dead signin code (SigninGlobalError) > > BUG=none > > Committed: https://crrev.com/c91b178b07b0d9fb0c7a437df3a1da3db1887160 > Cr-Commit-Position: refs/heads/master@{#344176} TBR=anthonyvd@chromium.org,sky@chromium.org,rogerta@chromium.org,estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/7529916efbda5763f6b5ddd9256ea46e29065281 Cr-Commit-Position: refs/heads/master@{#344188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+987 lines, -6 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 5 chunks +58 lines, -0 lines 0 comments Download
M chrome/browser/app_controller_mac_unittest.mm View 1 chunk +132 lines, -0 lines 0 comments Download
A chrome/browser/signin/signin_global_error.h View 1 chunk +71 lines, -0 lines 0 comments Download
A chrome/browser/signin/signin_global_error.cc View 1 chunk +196 lines, -0 lines 0 comments Download
A chrome/browser/signin/signin_global_error_factory.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/signin/signin_global_error_factory.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/browser/signin/signin_global_error_unittest.cc View 1 chunk +170 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.h View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_ui_util.cc View 2 chunks +67 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 7 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 4 chunks +35 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 8 chunks +69 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Adam Rice
Created Revert of Delete dead signin code (SigninGlobalError)
5 years, 4 months ago (2015-08-19 09:30:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301583004/1
5 years, 4 months ago (2015-08-19 09:31:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 09:32:12 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 09:32:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7529916efbda5763f6b5ddd9256ea46e29065281
Cr-Commit-Position: refs/heads/master@{#344188}

Powered by Google App Engine
This is Rietveld 408576698