chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 1301583004: Revert of Delete dead signin code (SigninGlobalError)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1301583004: Revert of Delete dead signin code (SigninGlobalError) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_command_controller_unittest.cc ('k') | chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index 4598c967ac0c93092ed87c8a1d898fed853bd4a9..b86492f79da7f30b1b6dd650a603f6e73c7dfe09 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -1148,6 +1148,14 @@

}

break;

}

+ case IDC_SHOW_SIGNIN: {

+ Profile* original_profile =

+ browser_->profile()->GetOriginalProfile();

+ [AppController updateSigninItem:item

+ shouldShow:enable

+ currentProfile:original_profile];

+ break;

+ }

case IDC_BOOKMARK_PAGE: {

// Extensions have the ability to hide the bookmark page menu item.

// This only affects the bookmark page menu item under the main menu.

« no previous file with comments | « chrome/browser/ui/browser_command_controller_unittest.cc ('k') | chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm » ('j') | no next file with comments »