Revert of Delete dead signin code (SigninGlobalError)

chrome/browser/ui/cocoa/panels/panel_cocoa_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <Carbon/Carbon.h>
 #import <Cocoa/Cocoa.h>
 
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/mac/scoped_nsautorelease_pool.h"
@@ skipping 290 matching lines @@
   NSMenuItem* new_tab_window_item = CreateMenuItem(menu, IDC_NEW_WINDOW);
   NSMenuItem* new_tab_incognito_window_item =
       CreateMenuItem(menu, IDC_NEW_INCOGNITO_WINDOW);
   NSMenuItem* close_window_menu_item = CreateMenuItem(menu, IDC_CLOSE_WINDOW);
   NSMenuItem* find_menu_item = CreateMenuItem(menu, IDC_FIND);
   NSMenuItem* find_previous_menu_item = CreateMenuItem(menu, IDC_FIND_PREVIOUS);
   NSMenuItem* find_next_menu_item = CreateMenuItem(menu, IDC_FIND_NEXT);
   NSMenuItem* fullscreen_menu_item = CreateMenuItem(menu, IDC_FULLSCREEN);
   NSMenuItem* presentation_menu_item =
       CreateMenuItem(menu, IDC_PRESENTATION_MODE);
+  NSMenuItem* sync_menu_item = CreateMenuItem(menu, IDC_SHOW_SYNC_SETUP);
   NSMenuItem* dev_tools_item = CreateMenuItem(menu, IDC_DEV_TOOLS);
   NSMenuItem* dev_tools_console_item =
       CreateMenuItem(menu, IDC_DEV_TOOLS_CONSOLE);
 
   PanelCocoa* native_window = static_cast<PanelCocoa*>(panel->native_panel());
   PanelWindowControllerCocoa* panel_controller = native_window->controller_;
   for (NSMenuItem *item in [menu itemArray])
     [item setTarget:panel_controller];
 
   [menu update];  // Trigger validation of menu items.
   EXPECT_FALSE([close_tab_menu_item isEnabled]);
   EXPECT_TRUE([close_window_menu_item isEnabled]);
   // No find support. Panels don't have a find bar.
   EXPECT_FALSE([find_menu_item isEnabled]);
   EXPECT_FALSE([find_previous_menu_item isEnabled]);
   EXPECT_FALSE([find_next_menu_item isEnabled]);
   EXPECT_FALSE([fullscreen_menu_item isEnabled]);
   EXPECT_FALSE([presentation_menu_item isEnabled]);
+  EXPECT_FALSE([sync_menu_item isEnabled]);
   // These are not enabled by Panel, so they are expected to be disabled for
   // this unit_test. In real Chrome app, they are enabled by Chrome NSApp
   // controller. PanelCocoaBrowsertest.MenuItems verifies that.
   EXPECT_FALSE([new_tab_menu_item isEnabled]);
   EXPECT_FALSE([new_tab_window_item isEnabled]);
   EXPECT_FALSE([new_tab_incognito_window_item isEnabled]);
 
   EXPECT_TRUE([dev_tools_item isEnabled]);
   EXPECT_TRUE([dev_tools_console_item isEnabled]);
 
+  // Verify that commandDispatch on an invalid menu item does not crash.
+  [NSApp sendAction:[sync_menu_item action]
+                 to:[sync_menu_item target]
+               from:sync_menu_item];
+
   ClosePanelAndWait(panel);
 }
 
 TEST_F(PanelCocoaTest, KeyEvent) {
   Panel* panel = CreateTestPanel("Test Panel");
   NSEvent* event = [NSEvent keyEventWithType:NSKeyDown
                                     location:NSZeroPoint
                                modifierFlags:NSControlKeyMask
                                    timestamp:0.0
                                 windowNumber:0
@@ skipping 45 matching lines @@
   EXPECT_NSEQ(frontmostWindow, [native_window->controller_ window]);
 
   native_window2->ActivatePanel();
   chrome::testing::NSRunLoopRunAllPending();
   frontmostWindow = [[NSApp orderedWindows] objectAtIndex:0];
   EXPECT_NSEQ(frontmostWindow, [native_window2->controller_ window]);
 
   ClosePanelAndWait(panel);
   ClosePanelAndWait(panel2);
 }