Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1301563003: Revert of Allow url::SchemeHostPort to hold non-file scheme without port (Closed)

Created:
5 years, 4 months ago by msramek
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow url::SchemeHostPort to hold non-file scheme without port (patchset #16 id:320001 of https://codereview.chromium.org/1272113002/ ) Reason for revert: Broken build. http://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/17899/steps/compile/logs/stdio Original issue's description: > Allow url::SchemeHostPort to hold non-file scheme without port > > WebSockets use url::Origin to pass origin info between renderer and > browser. Currently, it cannot hold an origin with non-file scheme and > no port. Chrome extensions have been using such origins, so we need > to keep the channel to convey origin info work for such origins. > > BUG=516971 > R=sleevi,brettw > > Committed: https://crrev.com/1ac9ec7bccd1b5178b18338b10149f36292f5fb6 > Cr-Commit-Position: refs/heads/master@{#343895} TBR=rsleevi@chromium.org,mkwst@chromium.org,brettw@chromium.org,tyoshino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516971 Committed: https://crrev.com/9b7972dd82ae09d1d1c38c6078bc384759eb18ee Cr-Commit-Position: refs/heads/master@{#343898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -312 lines) Patch
M chrome/browser/chromeos/fileapi/file_system_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 chunk +14 lines, -26 lines 0 comments Download
M chrome/common/chrome_content_client_unittest.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M components/test/run_all_unittests.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/url_schemes.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/public/common/content_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/shell/common/shell_content_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M extensions/shell/common/shell_content_client.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M extensions/test/extensions_unittests_main.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M google_apis/drive/drive_api_url_generator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/ios_chrome_unit_test_suite.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/runner/url_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M url/scheme_host_port.h View 1 chunk +10 lines, -9 lines 0 comments Download
M url/scheme_host_port.cc View 4 chunks +50 lines, -103 lines 0 comments Download
M url/url_util.h View 3 chunks +3 lines, -30 lines 0 comments Download
M url/url_util.cc View 11 chunks +22 lines, -45 lines 0 comments Download
M url/url_util_unittest.cc View 2 chunks +1 line, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msramek
Created Revert of Allow url::SchemeHostPort to hold non-file scheme without port
5 years, 4 months ago (2015-08-18 13:03:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301563003/1
5 years, 4 months ago (2015-08-18 13:03:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 13:04:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9b7972dd82ae09d1d1c38c6078bc384759eb18ee Cr-Commit-Position: refs/heads/master@{#343898}
5 years, 4 months ago (2015-08-18 13:05:18 UTC) #4
tyoshino (SeeGerritForStatus)
5 years, 4 months ago (2015-08-19 03:45:18 UTC) #5
Message was sent while issue was closed.
lgtm
Thanks for taking care of the issue.

Powered by Google App Engine
This is Rietveld 408576698