Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: url/url_util_unittest.cc

Issue 1301563003: Revert of Allow url::SchemeHostPort to hold non-file scheme without port (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « url/url_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/url_util_unittest.cc
diff --git a/url/url_util_unittest.cc b/url/url_util_unittest.cc
index b89bfa162e0db7558d7e50e072b466d2f1b3d321..929776584340b043486585fd30bfb6d2e3c7042e 100644
--- a/url/url_util_unittest.cc
+++ b/url/url_util_unittest.cc
@@ -59,38 +59,6 @@
static_cast<int>(strlen(ctrl_str)),
"javascript", &found_scheme));
EXPECT_TRUE(found_scheme == Component(1, 11));
-}
-
-TEST(URLUtilTest, IsStandard) {
- const char kHTTPScheme[] = "http";
- EXPECT_TRUE(IsStandard(kHTTPScheme, Component(0, strlen(kHTTPScheme))));
-
- const char kFooScheme[] = "foo";
- EXPECT_FALSE(IsStandard(kFooScheme, Component(0, strlen(kFooScheme))));
-}
-
-TEST(URLUtilTest, GetStandardSchemeType) {
- url::SchemeType scheme_type;
-
- const char kHTTPScheme[] = "http";
- scheme_type = url::SCHEME_WITHOUT_AUTHORITY;
- EXPECT_TRUE(GetStandardSchemeType(kHTTPScheme,
- Component(0, strlen(kHTTPScheme)),
- &scheme_type));
- EXPECT_EQ(url::SCHEME_WITH_PORT, scheme_type);
-
- const char kFilesystemScheme[] = "filesystem";
- scheme_type = url::SCHEME_WITH_PORT;
- EXPECT_TRUE(GetStandardSchemeType(kFilesystemScheme,
- Component(0, strlen(kFilesystemScheme)),
- &scheme_type));
- EXPECT_EQ(url::SCHEME_WITHOUT_AUTHORITY, scheme_type);
-
- const char kFooScheme[] = "foo";
- scheme_type = url::SCHEME_WITH_PORT;
- EXPECT_FALSE(GetStandardSchemeType(kFooScheme,
- Component(0, strlen(kFooScheme)),
- &scheme_type));
}
TEST(URLUtilTest, ReplaceComponents) {
@@ -252,7 +220,7 @@
}
TEST(URLUtilTest, TestResolveRelativeWithNonStandardBase) {
- // This tests non-standard (in the sense that IsStandard() == false)
+ // This tests non-standard (in the sense that GIsStandard() == false)
// hierarchical schemes.
struct ResolveRelativeCase {
const char* base;
« no previous file with comments | « url/url_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698