tools/check_git_config.py - Issue 1301453003: Fix encoding issue in check_git_config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/check_git_config.py

Issue 1301453003: Fix encoding issue in check_git_config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/check_git_config.py

diff --git a/tools/check_git_config.py b/tools/check_git_config.py

index ecdfc44273a8099c2469396c73612f2be07b7802..17b0d1ef4d742b015977d565531a24413e9932c4 100755

--- a/tools/check_git_config.py

+++ b/tools/check_git_config.py

@@ -111,7 +111,7 @@ def read_git_config(prop):

proc = subprocess.Popen(

[GIT_EXE, 'config', prop], stdout=subprocess.PIPE, cwd=REPO_ROOT)

out, _ = proc.communicate()

- return out.strip()

+ return out.strip().decode('utf-8')

except OSError as exc:

if exc.errno != errno.ENOENT:

logging.exception('Unexpected error when calling git')

« no previous file with comments | « no previous file | no next file » | no next file with comments »