Issue 1301423005: Move lineDirectionPointForBlockDirectionNavigationOf() to FrameSelection.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1301423005: Move lineDirectionPointForBlockDirectionNavigationOf() to FrameSelection.cpp (Closed)

Created:
5 years, 3 months ago by yosin_UTC9

Modified:
5 years, 3 months ago

Reviewers:
yoichio, hajimehoshi

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Move lineDirectionPointForBlockDirectionNavigationOf() to FrameSelection.cpp This patch moves |lineDirectionPointForBlockDirectionNavigationOf()| to "FrameSelection.cpp" as static function for improving code health since it used only in "FrameSelection.cpp". This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201523

Patch Set 1 : 2015-09-01T12:40:26 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -30 lines)			Patch
M	Source/core/editing/FrameSelection.cpp	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	Source/core/editing/VisiblePosition.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/core/editing/VisiblePosition.cpp	View	1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301423005/1

5 years, 3 months ago (2015-09-01 04:16:11 UTC) #4

commit-bot: I haz the power

5 years, 3 months ago (2015-09-01 05:46:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201523

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages