Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 1301423005: Move lineDirectionPointForBlockDirectionNavigationOf() to FrameSelection.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T12:40:26 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 0555c26c42ce29ef1e6ee4d09795280f23552079..5ee3ae88b94a0ed58b7cef9c7f6112b224e46da9 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -625,29 +625,6 @@ IntRect absoluteCaretBoundsOf(const VisiblePosition& visiblePosition)
return layoutObject->localToAbsoluteQuad(FloatRect(localRect)).enclosingBoundingBox();
}
-// TODO(yosin) We should move a global function
-// |lineDirectionPointForBlockDirectionNavigationOf()| to "FrameSelection.h"
-// as static function.
-int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition& visiblePosition)
-{
- if (visiblePosition.isNull())
- return 0;
-
- LayoutObject* layoutObject;
- LayoutRect localRect = localCaretRectOfPosition(visiblePosition.toPositionWithAffinity(), layoutObject);
- if (localRect.isEmpty() || !layoutObject)
- return 0;
-
- // This ignores transforms on purpose, for now. Vertical navigation is done
- // without consulting transforms, so that 'up' in transformed text is 'up'
- // relative to the text, not absolute 'up'.
- FloatPoint caretPoint = layoutObject->localToAbsolute(FloatPoint(localRect.location()));
- LayoutObject* containingBlock = layoutObject->containingBlock();
- if (!containingBlock)
- containingBlock = layoutObject; // Just use ourselves to determine the writing mode if we have no containing block.
- return containingBlock->isHorizontalWritingMode() ? caretPoint.x() : caretPoint.y();
-}
-
#ifndef NDEBUG
void VisiblePosition::debugPosition(const char* msg) const
« no previous file with comments | « Source/core/editing/VisiblePosition.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698