Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: Source/core/editing/VisiblePosition.h

Issue 1301423005: Move lineDirectionPointForBlockDirectionNavigationOf() to FrameSelection.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T12:40:26 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 // TODO(yosin) We should use |PositionWithAffinity| to make 110 // TODO(yosin) We should use |PositionWithAffinity| to make
111 // |toPositionWithAffinity()| simpler. 111 // |toPositionWithAffinity()| simpler.
112 Position m_deepPosition; 112 Position m_deepPosition;
113 TextAffinity m_affinity; 113 TextAffinity m_affinity;
114 }; 114 };
115 115
116 // TODO(yosin) We should move |absoluteCaretBoundsOf()| to "VisibleUnits.cpp". 116 // TODO(yosin) We should move |absoluteCaretBoundsOf()| to "VisibleUnits.cpp".
117 // Bounds of (possibly transformed) caret in absolute coords 117 // Bounds of (possibly transformed) caret in absolute coords
118 CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePosition&); 118 CORE_EXPORT IntRect absoluteCaretBoundsOf(const VisiblePosition&);
119 119
120 // Abs x/y position of the caret ignoring transforms.
121 // TODO(yosin) navigation with transforms should be smarter.
122 // TODO(yosin) We should move a glboal funciton
123 // |lineDirectionPointForBlockDirectionNavigationOf()| to "FrameSelection.h"
124 // as static function.
125 int lineDirectionPointForBlockDirectionNavigationOf(const VisiblePosition&);
126
127 // TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to 120 // TODO(yosin) We should move |leftPositionOf()| and |rightPositionOf()| to
128 // "VisibleUnits.cpp". 121 // "VisibleUnits.cpp".
129 VisiblePosition leftPositionOf(const VisiblePosition&); 122 VisiblePosition leftPositionOf(const VisiblePosition&);
130 VisiblePosition rightPositionOf(const VisiblePosition&); 123 VisiblePosition rightPositionOf(const VisiblePosition&);
131 124
132 CORE_EXPORT Position canonicalPositionOf(const Position&); 125 CORE_EXPORT Position canonicalPositionOf(const Position&);
133 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedT ree&); 126 CORE_EXPORT PositionInComposedTree canonicalPositionOf(const PositionInComposedT ree&);
134 127
135 // TODO(yosin) We should move |characterAfter()| and |characterBefore()| to 128 // TODO(yosin) We should move |characterAfter()| and |characterBefore()| to
136 // "VisibleUnits.cpp" 129 // "VisibleUnits.cpp"
(...skipping 13 matching lines...) Expand all
150 143
151 } // namespace blink 144 } // namespace blink
152 145
153 #ifndef NDEBUG 146 #ifndef NDEBUG
154 // Outside the WebCore namespace for ease of invocation from gdb. 147 // Outside the WebCore namespace for ease of invocation from gdb.
155 void showTree(const blink::VisiblePosition*); 148 void showTree(const blink::VisiblePosition*);
156 void showTree(const blink::VisiblePosition&); 149 void showTree(const blink::VisiblePosition&);
157 #endif 150 #endif
158 151
159 #endif // VisiblePosition_h 152 #endif // VisiblePosition_h
OLDNEW
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/editing/VisiblePosition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698