Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1300813002: Get rid of a redundant function Position::deprecatedEditingOffset() (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of a redundant function Position::deprecatedEditingOffset() This patch gets rid of a |Position::deprecatedEditingOffset()| by replacing them to |computeEditingOffset()|, since |deprecatedEditingOffset()| is just calling a |computeEditingOffset()| to simplify code for improving code health. BUG=513114 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200779

Patch Set 1 : 2015-08-18T17:24:05 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M Source/core/editing/Position.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/editing/Position.cpp View 4 chunks +3 lines, -11 lines 0 comments Download
M Source/core/editing/PositionIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-18 09:05:22 UTC) #2
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-18 09:12:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300813002/1
5 years, 4 months ago (2015-08-18 09:12:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94546)
5 years, 4 months ago (2015-08-18 13:10:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300813002/1
5 years, 4 months ago (2015-08-19 00:45:36 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 01:48:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200779

Powered by Google App Engine
This is Rietveld 408576698