Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: Source/core/editing/Position.cpp

Issue 1300813002: Get rid of a redundant function Position::deprecatedEditingOffset() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-18T17:24:05 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/Position.h ('k') | Source/core/editing/PositionIterator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Position.cpp
diff --git a/Source/core/editing/Position.cpp b/Source/core/editing/Position.cpp
index 894093b8bc42feef35f40f163911e951d441b40b..1befe556f68069f77215b41cf85e3aabd3df98d3 100644
--- a/Source/core/editing/Position.cpp
+++ b/Source/core/editing/Position.cpp
@@ -204,14 +204,6 @@ int PositionAlgorithm<Strategy>::computeEditingOffset() const
return m_offset;
}
-// TODO(yosin) We should replace all usage of |deprecatedEditingOffset()| by
-// |computeEditingOffset()|.
-template <typename Strategy>
-int PositionAlgorithm<Strategy>::deprecatedEditingOffset() const
-{
- return computeEditingOffset();
-}
-
template <typename Strategy>
Node* PositionAlgorithm<Strategy>::computeNodeBeforePosition() const
{
@@ -328,7 +320,7 @@ PositionAlgorithm<Strategy> PositionAlgorithm<Strategy>::previous(PositionMoveTy
if (!node)
return PositionAlgorithm<Strategy>(*this);
- int offset = deprecatedEditingOffset();
+ int offset = computeEditingOffset();
if (offset > 0) {
if (editingIgnoresContent(node))
@@ -370,7 +362,7 @@ PositionAlgorithm<Strategy> PositionAlgorithm<Strategy>::next(PositionMoveType m
if (!node)
return PositionAlgorithm<Strategy>(*this);
- int offset = deprecatedEditingOffset();
+ int offset = computeEditingOffset();
if (Node* child = Strategy::childAt(*node, offset))
return firstPositionInOrBeforeNode(child);
@@ -1023,7 +1015,7 @@ template <typename Strategy>
InlineBoxPosition PositionAlgorithm<Strategy>::computeInlineBoxPosition(EAffinity affinity, TextDirection primaryDirection) const
{
InlineBox* inlineBox = nullptr;
- int caretOffset = deprecatedEditingOffset();
+ int caretOffset = computeEditingOffset();
LayoutObject* layoutObject = m_anchorNode->isShadowRoot() ? toShadowRoot(m_anchorNode)->host()->layoutObject() : m_anchorNode->layoutObject();
if (!layoutObject->isText()) {
« no previous file with comments | « Source/core/editing/Position.h ('k') | Source/core/editing/PositionIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698