Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: Source/core/editing/Position.h

Issue 1300813002: Get rid of a redundant function Position::deprecatedEditingOffset() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-18T17:24:05 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 // |anchorNode()| function: 130 // |anchorNode()| function:
131 // - OffsetInAnchor m_offset 131 // - OffsetInAnchor m_offset
132 // - BeforeChildren 0 132 // - BeforeChildren 0
133 // - BeforeAnchor 0 133 // - BeforeAnchor 0
134 // - AfterChildren last editing offset in anchor node 134 // - AfterChildren last editing offset in anchor node
135 // - AfterAnchor last editing offset in anchor node 135 // - AfterAnchor last editing offset in anchor node
136 // Editing operations will change in anchor node rather than nodes around 136 // Editing operations will change in anchor node rather than nodes around
137 // anchor node. 137 // anchor node.
138 int computeEditingOffset() const; 138 int computeEditingOffset() const;
139 139
140 // New code should not use this function.
141 int deprecatedEditingOffset() const;
142
143 // These are convenience methods which are smart about whether the position is neighbor anchored or parent anchored 140 // These are convenience methods which are smart about whether the position is neighbor anchored or parent anchored
144 Node* computeNodeBeforePosition() const; 141 Node* computeNodeBeforePosition() const;
145 Node* computeNodeAfterPosition() const; 142 Node* computeNodeAfterPosition() const;
146 143
147 // Returns node as |Range::firstNode()|. This position must be a 144 // Returns node as |Range::firstNode()|. This position must be a
148 // |PositionAnchorType::OffsetInAhcor| to behave as |Range| boundary point. 145 // |PositionAnchorType::OffsetInAhcor| to behave as |Range| boundary point.
149 Node* nodeAsRangeFirstNode() const; 146 Node* nodeAsRangeFirstNode() const;
150 147
151 // Similar to |nodeAsRangeLastNode()|, but returns a node in a range. 148 // Similar to |nodeAsRangeLastNode()|, but returns a node in a range.
152 Node* nodeAsRangeLastNode() const; 149 Node* nodeAsRangeLastNode() const;
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 452
456 } // namespace blink 453 } // namespace blink
457 454
458 #ifndef NDEBUG 455 #ifndef NDEBUG
459 // Outside the WebCore namespace for ease of invocation from gdb. 456 // Outside the WebCore namespace for ease of invocation from gdb.
460 void showTree(const blink::Position&); 457 void showTree(const blink::Position&);
461 void showTree(const blink::Position*); 458 void showTree(const blink::Position*);
462 #endif 459 #endif
463 460
464 #endif // Position_h 461 #endif // Position_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698