Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: src/objects-debug.cc

Issue 1300363002: Fix bug in Code::VerifyRecompiledCode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-522895.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/disasm.h" 8 #include "src/disasm.h"
9 #include "src/disassembler.h" 9 #include "src/disassembler.h"
10 #include "src/macro-assembler.h" 10 #include "src/macro-assembler.h"
(...skipping 1277 matching lines...) Expand 10 before | Expand all | Expand 10 after
1288 // in the new code. 1288 // in the new code.
1289 while (!old_it.done() && !new_it.done()) { 1289 while (!old_it.done() && !new_it.done()) {
1290 Code* old_target = 1290 Code* old_target =
1291 Code::GetCodeFromTargetAddress(old_it.rinfo()->target_address()); 1291 Code::GetCodeFromTargetAddress(old_it.rinfo()->target_address());
1292 Code* new_target = 1292 Code* new_target =
1293 Code::GetCodeFromTargetAddress(new_it.rinfo()->target_address()); 1293 Code::GetCodeFromTargetAddress(new_it.rinfo()->target_address());
1294 CHECK_EQ(old_target->kind(), new_target->kind()); 1294 CHECK_EQ(old_target->kind(), new_target->kind());
1295 // Check call target for equality unless it's an IC or an interrupt check. 1295 // Check call target for equality unless it's an IC or an interrupt check.
1296 // In both cases they may be patched to be something else. 1296 // In both cases they may be patched to be something else.
1297 if (!old_target->is_handler() && !old_target->is_inline_cache_stub() && 1297 if (!old_target->is_handler() && !old_target->is_inline_cache_stub() &&
1298 new_target == isolate->builtins()->builtin(Builtins::kInterruptCheck)) { 1298 new_target != isolate->builtins()->builtin(Builtins::kInterruptCheck)) {
1299 CHECK_EQ(old_target, new_target); 1299 CHECK_EQ(old_target, new_target);
1300 } 1300 }
1301 old_it.next(); 1301 old_it.next();
1302 new_it.next(); 1302 new_it.next();
1303 } 1303 }
1304 1304
1305 // Both are done at the same time. 1305 // Both are done at the same time.
1306 CHECK_EQ(new_it.done(), old_it.done()); 1306 CHECK_EQ(new_it.done(), old_it.done());
1307 } 1307 }
1308 1308
1309 1309
1310 #endif // DEBUG 1310 #endif // DEBUG
1311 1311
1312 } // namespace internal 1312 } // namespace internal
1313 } // namespace v8 1313 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-522895.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698