Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1300263002: Don't bother running realpath in DeviceUtils._GetChangedAndStaleFiles() (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 4 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@device5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't bother running realpath in DeviceUtils._GetChangedAndStaleFiles() Shaves off a single adb command from managed_install.py (~150ms) BUG=520082 Committed: https://crrev.com/298f31eca43d36d67f6cbc8b2d2a495c5a625f1d Cr-Commit-Position: refs/heads/master@{#345129}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M build/android/pylib/device/device_utils.py View 1 3 chunks +8 lines, -17 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
agrieve
Can't figure out why it was ever being run in the first place. Original CL ...
5 years, 4 months ago (2015-08-20 01:09:12 UTC) #2
jbudorick
On 2015/08/20 at 01:09:12, agrieve wrote: > Can't figure out why it was ever being ...
5 years, 4 months ago (2015-08-23 02:19:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300263002/20001
5 years, 4 months ago (2015-08-24 17:50:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 18:43:03 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/298f31eca43d36d67f6cbc8b2d2a495c5a625f1d Cr-Commit-Position: refs/heads/master@{#345129}
5 years, 4 months ago (2015-08-24 18:43:58 UTC) #8
agrieve
5 years, 3 months ago (2015-08-26 13:55:29 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1306883004/ by agrieve@chromium.org.

The reason for reverting is: md5sum prints realpath, so this is actually still
necessary unless we change md5sum to print paths given..

Powered by Google App Engine
This is Rietveld 408576698