Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 1304713003: DeviceUtils.PushChangedFiles(): Don't run mkdir when it's not necessary (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 4 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@device6
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils.PushChangedFiles(): Don't run mkdir when it's not necessary Shaves off a single adb command from managed_install.py (~150ms) BUG=520082 Committed: https://crrev.com/93135fd37e66a5783580e12850f143675123c019 Cr-Commit-Position: refs/heads/master@{#345145}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M build/android/pylib/device/device_utils.py View 1 3 chunks +21 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
agrieve
5 years, 4 months ago (2015-08-20 02:12:17 UTC) #2
jbudorick
lgtm
5 years, 4 months ago (2015-08-23 02:21:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304713003/20001
5 years, 4 months ago (2015-08-24 18:49:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 19:27:50 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 19:28:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93135fd37e66a5783580e12850f143675123c019
Cr-Commit-Position: refs/heads/master@{#345145}

Powered by Google App Engine
This is Rietveld 408576698