Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1297903004: Fix `device.PushChangedFiles(delete_device_stale=True)` when no device files currently exist (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-managed-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix `device.PushChangedFiles(delete_device_stale=True)` when no device files currently exist It would try to run "rm -f", which fails without any args BUG= Committed: https://crrev.com/68a405ad1e13e9874265fc82f02bf55d65cb7ebd Cr-Commit-Position: refs/heads/master@{#345111}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M build/android/pylib/device/device_utils.py View 1 chunk +3 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
agrieve
5 years, 4 months ago (2015-08-19 14:09:56 UTC) #2
jbudorick
lgtm
5 years, 4 months ago (2015-08-19 14:14:22 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1291793007 Patch 1). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-19 18:02:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297903004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297903004/20001
5 years, 3 months ago (2015-08-24 17:02:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-24 17:40:16 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-24 17:40:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68a405ad1e13e9874265fc82f02bf55d65cb7ebd
Cr-Commit-Position: refs/heads/master@{#345111}

Powered by Google App Engine
This is Rietveld 408576698