Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287053004: MD downloads: implement real incognito marker courtesy of bettes@ (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@crbug-520709
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD downloads: implement real incognito marker courtesy of bettes@ R=groby@chromium.org BUG=520708 Committed: https://crrev.com/9c0437d5dfd9c44c0b2fbde7a891365455daf24f Cr-Commit-Position: refs/heads/master@{#343838}

Patch Set 1 #

Patch Set 2 : shuffle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
A chrome/browser/resources/md_downloads/1x/incognito_marker.png View Binary file 0 comments Download
A chrome/browser/resources/md_downloads/2x/incognito_marker.png View Binary file 0 comments Download
M chrome/browser/resources/md_downloads/item.css View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1300473002 Patch 20001

Dependent Patchsets:

Issue 1299803002 Patch 20001

Messages

Total messages: 7 (1 generated)
Dan Beam
screenshot: http://i.imgur.com/e7komtZ.png
5 years, 4 months ago (2015-08-15 01:06:50 UTC) #1
Dan Beam
ping groby@
5 years, 4 months ago (2015-08-17 18:00:52 UTC) #2
groby-ooo-7-16
lgtm
5 years, 4 months ago (2015-08-17 19:17:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287053004/20001
5 years, 4 months ago (2015-08-18 05:28:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 06:43:54 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 06:44:34 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9c0437d5dfd9c44c0b2fbde7a891365455daf24f
Cr-Commit-Position: refs/heads/master@{#343838}

Powered by Google App Engine
This is Rietveld 408576698