Returning const by ref instead of const by value in ApplyBlockElementCommand::tagName() api

Returning const by ref instead of const by value in ApplyBlockElementCommand::tagName() api

TEST=n/a, since no behavior changes.

BUG=393155
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200817

[shiva.jm, 2015-08-19 08:32:16]

shiva.jm@samsung.com changed reviewers:
+ yutak@chromium.org

[shiva.jm, 2015-08-19 08:32:17]

pls have a look.

[Yuta Kitamura, 2015-08-19 09:21:02]

yutak@chromium.org changed reviewers:
+ yosin@chromium.org

[Yuta Kitamura, 2015-08-19 09:23:30]

I see little value in landing this change, because
making a copy of a QualifiedName is very cheap (just
like String).

Is there any concrete problem in your mind that's solved
by this change?

[yosin_UTC9, 2015-08-19 09:27:23]

lgtm

s/const by ref/const reference/
s/const by value/const value/

No need to have "api" in summary

Please add TEST=n/a; no behavior changes
in description.

[shiva.jm, 2015-08-19 09:57:51]

On 2015/08/19 09:27:23, Yosi_UTC9 wrote:
> lgtm
> 
> s/const by ref/const reference/
> s/const by value/const value/
> 
> No need to have "api" in summary
> 
> Please add TEST=n/a; no behavior changes
> in description.

done.

[shiva.jm, 2015-08-19 09:59:18]

On 2015/08/19 09:23:30, Yuta Kitamura wrote:
> I see little value in landing this change, because
> making a copy of a QualifiedName is very cheap (just
> like String).
> 
> Is there any concrete problem in your mind that's solved
> by this change?

No concrete problem as such, it's just optimization change.

[shiva.jm, 2015-08-19 09:59:33]

The CQ bit was checked by shiva.jm@samsung.com

[commit-bot: I haz the power, 2015-08-19 09:59:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1299463004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1299463004/1

[commit-bot: I haz the power, 2015-08-19 11:31:34]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200817