Source/core/editing/commands/ApplyBlockElementCommand.h - Issue 1299463004: Returning const by ref instead of const by value in ApplyBlockElementCommand::tagName() api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/commands/ApplyBlockElementCommand.h

Issue 1299463004: Returning const by ref instead of const by value in ApplyBlockElementCommand::tagName() api (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/commands/ApplyBlockElementCommand.h

diff --git a/Source/core/editing/commands/ApplyBlockElementCommand.h b/Source/core/editing/commands/ApplyBlockElementCommand.h

index b01471e4fa026407e059e2885635f522ebad58a7..e1905e1ca87620797c7b83b166c34cb82f3ee1eb 100644

--- a/Source/core/editing/commands/ApplyBlockElementCommand.h

+++ b/Source/core/editing/commands/ApplyBlockElementCommand.h

@@ -43,7 +43,7 @@ protected:

virtual void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection);

PassRefPtrWillBeRawPtr<HTMLElement> createBlockElement() const;

- const QualifiedName tagName() const { return m_tagName; }

+ const QualifiedName& tagName() const { return m_tagName; }

DECLARE_VIRTUAL_TRACE();

« no previous file with comments | « no previous file | no next file » | no next file with comments »