Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: Source/core/editing/commands/ApplyBlockElementCommand.h

Issue 1299463004: Returning const by ref instead of const by value in ApplyBlockElementCommand::tagName() api (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class ApplyBlockElementCommand : public CompositeEditCommand { 39 class ApplyBlockElementCommand : public CompositeEditCommand {
40 protected: 40 protected:
41 ApplyBlockElementCommand(Document&, const QualifiedName& tagName, const Atom icString& inlineStyle); 41 ApplyBlockElementCommand(Document&, const QualifiedName& tagName, const Atom icString& inlineStyle);
42 ApplyBlockElementCommand(Document&, const QualifiedName& tagName); 42 ApplyBlockElementCommand(Document&, const QualifiedName& tagName);
43 43
44 virtual void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection); 44 virtual void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection);
45 PassRefPtrWillBeRawPtr<HTMLElement> createBlockElement() const; 45 PassRefPtrWillBeRawPtr<HTMLElement> createBlockElement() const;
46 const QualifiedName tagName() const { return m_tagName; } 46 const QualifiedName& tagName() const { return m_tagName; }
47 47
48 DECLARE_VIRTUAL_TRACE(); 48 DECLARE_VIRTUAL_TRACE();
49 49
50 private: 50 private:
51 void doApply() final; 51 void doApply() final;
52 virtual void formatRange(const Position& start, const Position& end, const P osition& endOfSelection, RefPtrWillBeRawPtr<HTMLElement>&) = 0; 52 virtual void formatRange(const Position& start, const Position& end, const P osition& endOfSelection, RefPtrWillBeRawPtr<HTMLElement>&) = 0;
53 void rangeForParagraphSplittingTextNodesIfNeeded(const VisiblePosition&, Pos ition&, Position&); 53 void rangeForParagraphSplittingTextNodesIfNeeded(const VisiblePosition&, Pos ition&, Position&);
54 VisiblePosition endOfNextParagrahSplittingTextNodesIfNeeded(VisiblePosition& , Position&, Position&); 54 VisiblePosition endOfNextParagrahSplittingTextNodesIfNeeded(VisiblePosition& , Position&, Position&);
55 55
56 QualifiedName m_tagName; 56 QualifiedName m_tagName;
57 AtomicString m_inlineStyle; 57 AtomicString m_inlineStyle;
58 Position m_endOfLastParagraph; 58 Position m_endOfLastParagraph;
59 }; 59 };
60 60
61 } 61 }
62 62
63 #endif 63 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698