Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1299213002: Cleanup: Remove unncessary leave_frame parameter from stub cache. (Closed)

Created:
5 years, 4 months ago by mvstanton
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup: Remove unncessary leave_frame parameter from stub cache. BUG= Committed: https://crrev.com/fe432e1ace48c345c659c0bcb6a84798bca0b15e Cr-Commit-Position: refs/heads/master@{#30250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -109 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 6 chunks +8 lines, -13 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M src/ic/stub-cache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Yang, This parameter is a left-over from the days when vector-based loads were flagged. ...
5 years, 4 months ago (2015-08-19 13:05:35 UTC) #2
Yang
On 2015/08/19 13:05:35, mvstanton wrote: > Hi Yang, > This parameter is a left-over from ...
5 years, 4 months ago (2015-08-19 13:08:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1299213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1299213002/1
5 years, 4 months ago (2015-08-19 13:09:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 13:51:26 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 13:51:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fe432e1ace48c345c659c0bcb6a84798bca0b15e
Cr-Commit-Position: refs/heads/master@{#30250}

Powered by Google App Engine
This is Rietveld 408576698