Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: src/ic/mips64/ic-mips64.cc

Issue 1299213002: Cleanup: Remove unncessary leave_frame parameter from stub cache. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips/stub-cache-mips.cc ('k') | src/ic/mips64/stub-cache-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 DCHECK(!AreAliased(vector, slot, a4, a5, a6, t1)); 432 DCHECK(!AreAliased(vector, slot, a4, a5, a6, t1));
433 Handle<TypeFeedbackVector> dummy_vector = 433 Handle<TypeFeedbackVector> dummy_vector =
434 TypeFeedbackVector::DummyVector(masm->isolate()); 434 TypeFeedbackVector::DummyVector(masm->isolate());
435 int slot_index = dummy_vector->GetIndex( 435 int slot_index = dummy_vector->GetIndex(
436 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot)); 436 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot));
437 __ LoadRoot(vector, Heap::kDummyVectorRootIndex); 437 __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
438 __ li(slot, Operand(Smi::FromInt(slot_index))); 438 __ li(slot, Operand(Smi::FromInt(slot_index)));
439 439
440 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 440 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
441 Code::ComputeHandlerFlags(Code::LOAD_IC)); 441 Code::ComputeHandlerFlags(Code::LOAD_IC));
442 masm->isolate()->stub_cache()->GenerateProbe( 442 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, flags,
443 masm, Code::LOAD_IC, flags, false, receiver, key, a4, a5, a6, t1); 443 receiver, key, a4, a5, a6, t1);
444 // Cache miss. 444 // Cache miss.
445 GenerateMiss(masm); 445 GenerateMiss(masm);
446 446
447 // Do a quick inline probe of the receiver's dictionary, if it 447 // Do a quick inline probe of the receiver's dictionary, if it
448 // exists. 448 // exists.
449 __ bind(&probe_dictionary); 449 __ bind(&probe_dictionary);
450 // a3: elements 450 // a3: elements
451 __ ld(a0, FieldMemOperand(receiver, HeapObject::kMapOffset)); 451 __ ld(a0, FieldMemOperand(receiver, HeapObject::kMapOffset));
452 __ lbu(a0, FieldMemOperand(a0, Map::kInstanceTypeOffset)); 452 __ lbu(a0, FieldMemOperand(a0, Map::kInstanceTypeOffset));
453 GenerateGlobalInstanceTypeCheck(masm, a0, &slow); 453 GenerateGlobalInstanceTypeCheck(masm, a0, &slow);
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
683 Handle<TypeFeedbackVector> dummy_vector = 683 Handle<TypeFeedbackVector> dummy_vector =
684 TypeFeedbackVector::DummyVector(masm->isolate()); 684 TypeFeedbackVector::DummyVector(masm->isolate());
685 int slot_index = dummy_vector->GetIndex( 685 int slot_index = dummy_vector->GetIndex(
686 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot)); 686 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
687 __ LoadRoot(vector, Heap::kDummyVectorRootIndex); 687 __ LoadRoot(vector, Heap::kDummyVectorRootIndex);
688 __ li(slot, Operand(Smi::FromInt(slot_index))); 688 __ li(slot, Operand(Smi::FromInt(slot_index)));
689 } 689 }
690 690
691 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 691 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
692 Code::ComputeHandlerFlags(Code::STORE_IC)); 692 Code::ComputeHandlerFlags(Code::STORE_IC));
693 masm->isolate()->stub_cache()->GenerateProbe( 693 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags,
694 masm, Code::STORE_IC, flags, false, receiver, key, a3, a4, a5, a6); 694 receiver, key, a3, a4, a5, a6);
695 // Cache miss. 695 // Cache miss.
696 __ Branch(&miss); 696 __ Branch(&miss);
697 697
698 // Extra capacity case: Check if there is extra capacity to 698 // Extra capacity case: Check if there is extra capacity to
699 // perform the store and update the length. Used for adding one 699 // perform the store and update the length. Used for adding one
700 // element to the array by writing to array[array.length]. 700 // element to the array by writing to array[array.length].
701 __ bind(&extra); 701 __ bind(&extra);
702 // Condition code from comparing key and array length is still available. 702 // Condition code from comparing key and array length is still available.
703 // Only support writing to array[array.length]. 703 // Only support writing to array[array.length].
704 __ Branch(&slow, ne, key, Operand(a4)); 704 __ Branch(&slow, ne, key, Operand(a4));
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 void StoreIC::GenerateMegamorphic(MacroAssembler* masm) { 763 void StoreIC::GenerateMegamorphic(MacroAssembler* masm) {
764 Register receiver = StoreDescriptor::ReceiverRegister(); 764 Register receiver = StoreDescriptor::ReceiverRegister();
765 Register name = StoreDescriptor::NameRegister(); 765 Register name = StoreDescriptor::NameRegister();
766 DCHECK(receiver.is(a1)); 766 DCHECK(receiver.is(a1));
767 DCHECK(name.is(a2)); 767 DCHECK(name.is(a2));
768 DCHECK(StoreDescriptor::ValueRegister().is(a0)); 768 DCHECK(StoreDescriptor::ValueRegister().is(a0));
769 769
770 // Get the receiver from the stack and probe the stub cache. 770 // Get the receiver from the stack and probe the stub cache.
771 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 771 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
772 Code::ComputeHandlerFlags(Code::STORE_IC)); 772 Code::ComputeHandlerFlags(Code::STORE_IC));
773 masm->isolate()->stub_cache()->GenerateProbe( 773 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags,
774 masm, Code::STORE_IC, flags, false, receiver, name, a3, a4, a5, a6); 774 receiver, name, a3, a4, a5, a6);
775 775
776 // Cache miss: Jump to runtime. 776 // Cache miss: Jump to runtime.
777 GenerateMiss(masm); 777 GenerateMiss(masm);
778 } 778 }
779 779
780 780
781 void StoreIC::GenerateMiss(MacroAssembler* masm) { 781 void StoreIC::GenerateMiss(MacroAssembler* masm) {
782 StoreIC_PushArgs(masm); 782 StoreIC_PushArgs(masm);
783 783
784 // Perform tail call to the entry. 784 // Perform tail call to the entry.
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
900 patcher.ChangeBranchCondition(ne); 900 patcher.ChangeBranchCondition(ne);
901 } else { 901 } else {
902 DCHECK(Assembler::IsBne(branch_instr)); 902 DCHECK(Assembler::IsBne(branch_instr));
903 patcher.ChangeBranchCondition(eq); 903 patcher.ChangeBranchCondition(eq);
904 } 904 }
905 } 905 }
906 } // namespace internal 906 } // namespace internal
907 } // namespace v8 907 } // namespace v8
908 908
909 #endif // V8_TARGET_ARCH_MIPS64 909 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/ic/mips/stub-cache-mips.cc ('k') | src/ic/mips64/stub-cache-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698