Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: src/ic/ia32/ic-ia32.cc

Issue 1299213002: Cleanup: Remove unncessary leave_frame parameter from stub cache. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/stub-cache-arm64.cc ('k') | src/ic/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 Handle<TypeFeedbackVector> dummy_vector = 341 Handle<TypeFeedbackVector> dummy_vector =
342 TypeFeedbackVector::DummyVector(isolate); 342 TypeFeedbackVector::DummyVector(isolate);
343 int slot = dummy_vector->GetIndex( 343 int slot = dummy_vector->GetIndex(
344 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot)); 344 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedLoadICSlot));
345 __ push(Immediate(Smi::FromInt(slot))); 345 __ push(Immediate(Smi::FromInt(slot)));
346 __ push(Immediate(dummy_vector)); 346 __ push(Immediate(dummy_vector));
347 347
348 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 348 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
349 Code::ComputeHandlerFlags(Code::LOAD_IC)); 349 Code::ComputeHandlerFlags(Code::LOAD_IC));
350 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::KEYED_LOAD_IC, flags, 350 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::KEYED_LOAD_IC, flags,
351 false, receiver, key, ebx, edi); 351 receiver, key, ebx, edi);
352 352
353 __ pop(LoadWithVectorDescriptor::VectorRegister()); 353 __ pop(LoadWithVectorDescriptor::VectorRegister());
354 __ pop(LoadDescriptor::SlotRegister()); 354 __ pop(LoadDescriptor::SlotRegister());
355 355
356 // Cache miss. 356 // Cache miss.
357 GenerateMiss(masm); 357 GenerateMiss(masm);
358 358
359 // Do a quick inline probe of the receiver's dictionary, if it 359 // Do a quick inline probe of the receiver's dictionary, if it
360 // exists. 360 // exists.
361 __ bind(&probe_dictionary); 361 __ bind(&probe_dictionary);
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 Handle<TypeFeedbackVector> dummy_vector = 569 Handle<TypeFeedbackVector> dummy_vector =
570 TypeFeedbackVector::DummyVector(masm->isolate()); 570 TypeFeedbackVector::DummyVector(masm->isolate());
571 int slot = dummy_vector->GetIndex( 571 int slot = dummy_vector->GetIndex(
572 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot)); 572 FeedbackVectorICSlot(TypeFeedbackVector::kDummyKeyedStoreICSlot));
573 __ push(Immediate(Smi::FromInt(slot))); 573 __ push(Immediate(Smi::FromInt(slot)));
574 __ push(Immediate(dummy_vector)); 574 __ push(Immediate(dummy_vector));
575 } 575 }
576 576
577 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 577 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
578 Code::ComputeHandlerFlags(Code::STORE_IC)); 578 Code::ComputeHandlerFlags(Code::STORE_IC));
579 masm->isolate()->stub_cache()->GenerateProbe( 579 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags,
580 masm, Code::STORE_IC, flags, false, receiver, key, ebx, no_reg); 580 receiver, key, ebx, no_reg);
581 581
582 if (FLAG_vector_stores) { 582 if (FLAG_vector_stores) {
583 __ pop(VectorStoreICDescriptor::VectorRegister()); 583 __ pop(VectorStoreICDescriptor::VectorRegister());
584 __ pop(VectorStoreICDescriptor::SlotRegister()); 584 __ pop(VectorStoreICDescriptor::SlotRegister());
585 } 585 }
586 586
587 // Cache miss. 587 // Cache miss.
588 __ jmp(&miss); 588 __ jmp(&miss);
589 589
590 // Extra capacity case: Check if there is extra capacity to 590 // Extra capacity case: Check if there is extra capacity to
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 : Runtime::kKeyedGetProperty, 731 : Runtime::kKeyedGetProperty,
732 2, 1); 732 2, 1);
733 } 733 }
734 734
735 735
736 void StoreIC::GenerateMegamorphic(MacroAssembler* masm) { 736 void StoreIC::GenerateMegamorphic(MacroAssembler* masm) {
737 // Return address is on the stack. 737 // Return address is on the stack.
738 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( 738 Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(
739 Code::ComputeHandlerFlags(Code::STORE_IC)); 739 Code::ComputeHandlerFlags(Code::STORE_IC));
740 masm->isolate()->stub_cache()->GenerateProbe( 740 masm->isolate()->stub_cache()->GenerateProbe(
741 masm, Code::STORE_IC, flags, false, StoreDescriptor::ReceiverRegister(), 741 masm, Code::STORE_IC, flags, StoreDescriptor::ReceiverRegister(),
742 StoreDescriptor::NameRegister(), ebx, no_reg); 742 StoreDescriptor::NameRegister(), ebx, no_reg);
743 743
744 // Cache miss: Jump to runtime. 744 // Cache miss: Jump to runtime.
745 GenerateMiss(masm); 745 GenerateMiss(masm);
746 } 746 }
747 747
748 748
749 static void StoreIC_PushArgs(MacroAssembler* masm) { 749 static void StoreIC_PushArgs(MacroAssembler* masm) {
750 Register receiver = StoreDescriptor::ReceiverRegister(); 750 Register receiver = StoreDescriptor::ReceiverRegister();
751 Register name = StoreDescriptor::NameRegister(); 751 Register name = StoreDescriptor::NameRegister();
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
886 Condition cc = 886 Condition cc =
887 (check == ENABLE_INLINED_SMI_CHECK) 887 (check == ENABLE_INLINED_SMI_CHECK)
888 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 888 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
889 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 889 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
890 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 890 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
891 } 891 }
892 } // namespace internal 892 } // namespace internal
893 } // namespace v8 893 } // namespace v8
894 894
895 #endif // V8_TARGET_ARCH_IA32 895 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm64/stub-cache-arm64.cc ('k') | src/ic/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698