Issue 12989019: Put zapping of local handles behind the extra checks flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12989019: Put zapping of local handles behind the extra checks flag. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Put zapping of local handles behind the extra checks flag. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14048

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -19 lines)			Patch
M	src/api.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/api.cc	View		3 chunks	+2 lines, -10 lines	0 comments	Download
M	src/apiutils.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/handles.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/handles.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/handles-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://codereview.chromium.org/12989019/diff/1/src/handles.h File src/handles.h (right): https://codereview.chromium.org/12989019/diff/1/src/handles.h#newcode164 src/handles.h:164: static void ZapRange(internal::Object** start, internal::Object** end); ...

7 years, 9 months ago (2013-03-22 13:36:38 UTC) #2

Michael Starzinger

Addressed comments. Landing. https://codereview.chromium.org/12989019/diff/1/src/handles.h File src/handles.h (right): https://codereview.chromium.org/12989019/diff/1/src/handles.h#newcode164 src/handles.h:164: static void ZapRange(internal::Object** start, internal::Object** end); ...

7 years, 9 months ago (2013-03-22 13:39:54 UTC) #3

Michael Starzinger

7 years, 9 months ago (2013-03-22 13:40:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r14048 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12989019: Put zapping of local handles behind the extra checks flag. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Messages