Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: src/handles.cc

Issue 12989019: Put zapping of local handles behind the extra checks flag. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Jakob Kummerow. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/handles-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 } 94 }
95 95
96 96
97 void HandleScope::DeleteExtensions(Isolate* isolate) { 97 void HandleScope::DeleteExtensions(Isolate* isolate) {
98 v8::ImplementationUtilities::HandleScopeData* current = 98 v8::ImplementationUtilities::HandleScopeData* current =
99 isolate->handle_scope_data(); 99 isolate->handle_scope_data();
100 isolate->handle_scope_implementer()->DeleteExtensions(current->limit); 100 isolate->handle_scope_implementer()->DeleteExtensions(current->limit);
101 } 101 }
102 102
103 103
104 #ifdef ENABLE_EXTRA_CHECKS
104 void HandleScope::ZapRange(Object** start, Object** end) { 105 void HandleScope::ZapRange(Object** start, Object** end) {
105 ASSERT(end - start <= kHandleBlockSize); 106 ASSERT(end - start <= kHandleBlockSize);
106 for (Object** p = start; p != end; p++) { 107 for (Object** p = start; p != end; p++) {
107 *reinterpret_cast<Address*>(p) = v8::internal::kHandleZapValue; 108 *reinterpret_cast<Address*>(p) = v8::internal::kHandleZapValue;
108 } 109 }
109 } 110 }
111 #endif
110 112
111 113
112 Address HandleScope::current_level_address(Isolate* isolate) { 114 Address HandleScope::current_level_address(Isolate* isolate) {
113 return reinterpret_cast<Address>(&isolate->handle_scope_data()->level); 115 return reinterpret_cast<Address>(&isolate->handle_scope_data()->level);
114 } 116 }
115 117
116 118
117 Address HandleScope::current_next_address(Isolate* isolate) { 119 Address HandleScope::current_next_address(Isolate* isolate) {
118 return reinterpret_cast<Address>(&isolate->handle_scope_data()->next); 120 return reinterpret_cast<Address>(&isolate->handle_scope_data()->next);
119 } 121 }
(...skipping 808 matching lines...) Expand 10 before | Expand all | Expand 10 after
928 data->next = prev_next_; 930 data->next = prev_next_;
929 data->limit = prev_limit_; 931 data->limit = prev_limit_;
930 #ifdef DEBUG 932 #ifdef DEBUG
931 handles_detached_ = true; 933 handles_detached_ = true;
932 #endif 934 #endif
933 return deferred; 935 return deferred;
934 } 936 }
935 937
936 938
937 } } // namespace v8::internal 939 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/handles-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698