Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: src/handles.h

Issue 12989019: Put zapping of local handles behind the extra checks flag. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Jakob Kummerow. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/apiutils.h ('k') | src/handles.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 153
154 inline void CloseScope(); 154 inline void CloseScope();
155 155
156 Isolate* isolate_; 156 Isolate* isolate_;
157 Object** prev_next_; 157 Object** prev_next_;
158 Object** prev_limit_; 158 Object** prev_limit_;
159 159
160 // Extend the handle scope making room for more handles. 160 // Extend the handle scope making room for more handles.
161 static internal::Object** Extend(Isolate* isolate); 161 static internal::Object** Extend(Isolate* isolate);
162 162
163 #ifdef ENABLE_EXTRA_CHECKS
163 // Zaps the handles in the half-open interval [start, end). 164 // Zaps the handles in the half-open interval [start, end).
164 static void ZapRange(internal::Object** start, internal::Object** end); 165 static void ZapRange(internal::Object** start, internal::Object** end);
166 #endif
165 167
168 friend class v8::HandleScope;
166 friend class v8::internal::DeferredHandles; 169 friend class v8::internal::DeferredHandles;
167 friend class v8::HandleScope;
168 friend class v8::internal::HandleScopeImplementer; 170 friend class v8::internal::HandleScopeImplementer;
169 friend class v8::ImplementationUtilities;
170 friend class v8::internal::Isolate; 171 friend class v8::internal::Isolate;
171 }; 172 };
172 173
173 174
174 class DeferredHandles; 175 class DeferredHandles;
175 176
176 177
177 class DeferredHandleScope { 178 class DeferredHandleScope {
178 public: 179 public:
179 explicit DeferredHandleScope(Isolate* isolate); 180 explicit DeferredHandleScope(Isolate* isolate);
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 inline ~HandleDereferenceGuard(); 351 inline ~HandleDereferenceGuard();
351 private: 352 private:
352 Isolate* isolate_; 353 Isolate* isolate_;
353 bool old_state_; 354 bool old_state_;
354 #endif 355 #endif
355 }; 356 };
356 357
357 } } // namespace v8::internal 358 } } // namespace v8::internal
358 359
359 #endif // V8_HANDLES_H_ 360 #endif // V8_HANDLES_H_
OLDNEW
« no previous file with comments | « src/apiutils.h ('k') | src/handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698