Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1298863003: Remove VideoDecoder::Initialize(). (Closed)

Created:
5 years, 4 months ago by Sergey Ulanov
Modified:
5 years, 4 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove VideoDecoder::Initialize(). Initialize() function wasn't really useful in VideoDecoder. Initialization can be done when decoding the first frame. Committed: https://crrev.com/e8834ec844598e347aaa5ea642f81321becbfbff Cr-Commit-Position: refs/heads/master@{#344264}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -34 lines) Patch
M remoting/client/software_video_renderer.cc View 1 2 4 chunks +0 lines, -8 lines 0 comments Download
M remoting/codec/codec_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/codec/video_decoder.h View 2 chunks +1 line, -4 lines 0 comments Download
M remoting/codec/video_decoder_verbatim.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/codec/video_decoder_verbatim.cc View 1 1 chunk +12 lines, -12 lines 0 comments Download
M remoting/codec/video_decoder_vpx.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/codec/video_decoder_vpx.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M remoting/test/test_video_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Sergey Ulanov
This change was previously included in https://codereview.chromium.org/1288063004/, but it can be separate.
5 years, 4 months ago (2015-08-19 00:06:01 UTC) #2
Jamie
https://codereview.chromium.org/1298863003/diff/1/remoting/codec/video_decoder_verbatim.cc File remoting/codec/video_decoder_verbatim.cc (right): https://codereview.chromium.org/1298863003/diff/1/remoting/codec/video_decoder_verbatim.cc#newcode25 remoting/codec/video_decoder_verbatim.cc:25: screen_size_.height() * kBytesPerPixel]); Do you need to call updated_region_.Clear() ...
5 years, 4 months ago (2015-08-19 00:16:33 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1298863003/diff/1/remoting/codec/video_decoder_verbatim.cc File remoting/codec/video_decoder_verbatim.cc (right): https://codereview.chromium.org/1298863003/diff/1/remoting/codec/video_decoder_verbatim.cc#newcode25 remoting/codec/video_decoder_verbatim.cc:25: screen_size_.height() * kBytesPerPixel]); On 2015/08/19 00:16:32, Jamie wrote: > ...
5 years, 4 months ago (2015-08-19 00:43:53 UTC) #4
Jamie
lgtm
5 years, 4 months ago (2015-08-19 00:57:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298863003/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298863003/2
5 years, 4 months ago (2015-08-19 05:01:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/57457)
5 years, 4 months ago (2015-08-19 05:15:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298863003/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298863003/30001
5 years, 4 months ago (2015-08-19 16:42:09 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 4 months ago (2015-08-19 17:40:01 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 17:40:50 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e8834ec844598e347aaa5ea642f81321becbfbff
Cr-Commit-Position: refs/heads/master@{#344264}

Powered by Google App Engine
This is Rietveld 408576698