Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: remoting/client/software_video_renderer.cc

Issue 1298863003: Remove VideoDecoder::Initialize(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/codec/codec_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/software_video_renderer.cc
diff --git a/remoting/client/software_video_renderer.cc b/remoting/client/software_video_renderer.cc
index c8e257305ea84b6f9180a0ea054cdba6febe042a..bd9ccbc5902028ea5b45cd584aaa84ac5704a7b5 100644
--- a/remoting/client/software_video_renderer.cc
+++ b/remoting/client/software_video_renderer.cc
@@ -37,10 +37,6 @@ class RgbToBgrVideoDecoderFilter : public VideoDecoder {
: parent_(parent.Pass()) {
}
- void Initialize(const webrtc::DesktopSize& screen_size) override {
- parent_->Initialize(screen_size);
- }
-
bool DecodePacket(const VideoPacket& packet) override {
return parent_->DecodePacket(packet);
}
@@ -165,7 +161,6 @@ void SoftwareVideoRenderer::Core::DecodePacket(scoped_ptr<VideoPacket> packet,
const base::Closure& done) {
DCHECK(decode_task_runner_->BelongsToCurrentThread());
- bool decoder_needs_reset = false;
bool notify_size_or_dpi_change = false;
// If the packet includes screen size or DPI information, store them.
@@ -175,7 +170,6 @@ void SoftwareVideoRenderer::Core::DecodePacket(scoped_ptr<VideoPacket> packet,
packet->format().screen_height());
if (!source_size_.equals(source_size)) {
source_size_ = source_size;
- decoder_needs_reset = true;
notify_size_or_dpi_change = true;
}
}
@@ -194,8 +188,6 @@ void SoftwareVideoRenderer::Core::DecodePacket(scoped_ptr<VideoPacket> packet,
return;
}
- if (decoder_needs_reset)
- decoder_->Initialize(source_size_);
if (notify_size_or_dpi_change)
consumer_->SetSourceSize(source_size_, source_dpi_);
« no previous file with comments | « no previous file | remoting/codec/codec_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698