Source/core/layout/LayoutBlockFlow.h - Issue 1298603004: Ensure floats get added to floating objects list even if they don't have a linebox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlockFlow.h

Issue 1298603004: Ensure floats get added to floating objects list even if they don't have a linebox (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutBlockFlow.h

diff --git a/Source/core/layout/LayoutBlockFlow.h b/Source/core/layout/LayoutBlockFlow.h

index b93f4132eebcda07ea041d552c2720a2f7e070dd..bf7ae9d379002975cc06a8afe8ef406feafe1d3d 100644

--- a/Source/core/layout/LayoutBlockFlow.h

+++ b/Source/core/layout/LayoutBlockFlow.h

@@ -529,7 +529,7 @@ private:

void layoutRunsAndFloatsInRange(LineLayoutState&, InlineBidiResolver&,

const InlineIterator& cleanLineStart, const BidiStatus& cleanLineBidiStatus);

void linkToEndLineIfNeeded(LineLayoutState&);

- static void markDirtyFloatsForPaintInvalidation(Vector<FloatWithRect>& floats);

+ void markDirtyFloatsForPaintInvalidation(Vector<FloatWithRect>& floats);

RootInlineBox* determineStartPosition(LineLayoutState&, InlineBidiResolver&);

void determineEndPosition(LineLayoutState&, RootInlineBox* startBox, InlineIterator& cleanLineStart, BidiStatus& cleanLineBidiStatus);

bool lineBoxHasBRWithClearance(RootInlineBox*);

« no previous file with comments | « LayoutTests/fast/block/float/trailing-float-layout-expected.txt ('k') | Source/core/layout/LayoutBlockFlowLine.cpp » ('j') | no next file with comments »