Issue 1298483004: Fix Custom Action Bar for custom tabs on tablet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1298483004: Fix Custom Action Bar for custom tabs on tablet (Closed)

Created:
5 years, 4 months ago by Ian Wen

Modified:
5 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

Fix Custom Action Bar for custom tabs on tablet Custom tabs on tablet is special in that it does not have a tab strip. Therefore ContextualMenuBar will calculate the wrong offset when animating the bar. BUG=510284 Review URL: https://codereview.chromium.org/1292693002 Cr-Commit-Position: refs/heads/master@{#343437} TBR=dtrainor@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9984991d77cf2681a9701af63d00a1cd8b03b686

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -3 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/ContextualMenuBar.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java	View	2 chunks	+5 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

Ian Wen

5 years, 4 months ago (2015-08-14 21:11:17 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9984991d77cf2681a9701af63d00a1cd8b03b686 (presubmit successful).