Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Issue 1298483004: Fix Custom Action Bar for custom tabs on tablet (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@2454
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
index 16194fd395750377d75dc78e8deaa0fb0bf9b077..d12afea65e0a802ad4e01a480cb1bf26fbdaefbc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
@@ -185,9 +185,6 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe
// TODO(tedchoc): Add support for changing the color based on the brand color.
}
};
- mContextualMenuBar = new ContextualMenuBar(activity, mActionBarDelegate);
- mContextualMenuBar.setCustomSelectionActionModeCallback(
- new CustomSelectionActionModeCallback());
mToolbarModel = new ToolbarModelImpl();
mControlContainer = controlContainer;
@@ -197,6 +194,11 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe
mToolbar.setPaintInvalidator(invalidator);
+ mContextualMenuBar = new ContextualMenuBar(activity, mActionBarDelegate);
+ mContextualMenuBar.setCustomSelectionActionModeCallback(
+ new CustomSelectionActionModeCallback());
+ mContextualMenuBar.setTabStripHeight(mToolbar.getTabStripHeight());
+
MenuDelegatePhone menuDelegate = new MenuDelegatePhone() {
@Override
public void updateReloadButtonState(boolean isLoading) {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698