Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: net/http/http_cache.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed too much, back up a bit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache.h
diff --git a/net/http/http_cache.h b/net/http/http_cache.h
index 026d476e92f0dcfd36c309d07c5016ddfaa04854..c0618cc7bd6483d9f63fbc2a454b819a05dca497 100644
--- a/net/http/http_cache.h
+++ b/net/http/http_cache.h
@@ -126,23 +126,26 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
static const int kPrefetchReuseMins = 5;
// The disk cache is initialized lazily (by CreateTransaction) in this case.
- // The HttpCache takes ownership of the |backend_factory|.
- HttpCache(const HttpNetworkSession::Params& params,
- BackendFactory* backend_factory);
-
- // The disk cache is initialized lazily (by CreateTransaction) in this case.
// Provide an existing HttpNetworkSession, the cache can construct a
// network layer with a shared HttpNetworkSession in order for multiple
// network layers to share information (e.g. authentication data). The
// HttpCache takes ownership of the |backend_factory|.
- HttpCache(HttpNetworkSession* session, BackendFactory* backend_factory);
+ //
+ // The HttpCache must be destroyed before the HttpNetworkSession.
+ //
+ // If |set_up_quic_server_info| is true, configures the cache to track
+ // information about which servers support SPDY.
pauljensen 2015/09/02 14:32:29 SPDY->QUIC
mmenke 2015/09/02 16:29:34 Done.
+ HttpCache(HttpNetworkSession* session,
+ BackendFactory* backend_factory,
pauljensen 2015/09/02 14:32:29 should be a scoped_ptr...for another CL.
mmenke 2015/09/02 16:29:34 Almost did it in this CL, but just got too massive
+ bool set_up_quic_server_info);
// Initialize the cache from its component parts. The lifetime of the
// |network_layer| and |backend_factory| are managed by the HttpCache and
// will be destroyed using |delete| when the HttpCache is destroyed.
HttpCache(HttpTransactionFactory* network_layer,
pauljensen 2015/09/02 14:32:29 ditto
mmenke 2015/09/02 16:29:34 Acknowledged.
NetLog* net_log,
- BackendFactory* backend_factory);
+ BackendFactory* backend_factory,
pauljensen 2015/09/02 14:32:29 ditto
mmenke 2015/09/02 16:29:33 Acknowledged.
+ bool set_up_quic_server_info);
~HttpCache() override;

Powered by Google App Engine
This is Rietveld 408576698