Remove reference counting from HttpNetworkSession.

net/http/http_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file declares a HttpTransactionFactory implementation that can be
 // layered on top of another HttpTransactionFactory to add HTTP caching.  The
 // caching logic follows RFC 7234 (any exceptions are called out in the code).
 //
 // The HttpCache takes a disk_cache::Backend as a parameter, and uses that for
 // the cache storage.
@@ skipping 108 matching lines @@
     const base::FilePath path_;
     int max_bytes_;
     scoped_refptr<base::SingleThreadTaskRunner> thread_;
   };
 
   // The number of minutes after a resource is prefetched that it can be used
   // again without validation.
   static const int kPrefetchReuseMins = 5;
 
   // The disk cache is initialized lazily (by CreateTransaction) in this case.
-  // The HttpCache takes ownership of the |backend_factory|.
-  HttpCache(const HttpNetworkSession::Params& params,
-            BackendFactory* backend_factory);
-
-  // The disk cache is initialized lazily (by CreateTransaction) in this case.
   // Provide an existing HttpNetworkSession, the cache can construct a
   // network layer with a shared HttpNetworkSession in order for multiple
   // network layers to share information (e.g. authentication data). The
   // HttpCache takes ownership of the |backend_factory|.
-  HttpCache(HttpNetworkSession* session, BackendFactory* backend_factory);
+  //
+  // The HttpCache must be destroyed before the HttpNetworkSession.
+  //
+  // If |set_up_quic_server_info| is true, configures the cache to track
+  // information about which servers support SPDY.

[pauljensen, 2015/09/02 14:32:29]

SPDY->QUIC

[mmenke, 2015/09/02 16:29:34]

Done.

+  HttpCache(HttpNetworkSession* session,
+            BackendFactory* backend_factory,

[pauljensen, 2015/09/02 14:32:29]

should be a scoped_ptr...for another CL.

[mmenke, 2015/09/02 16:29:34]

Almost did it in this CL, but just got too massive.

+            bool set_up_quic_server_info);
 
   // Initialize the cache from its component parts. The lifetime of the
   // |network_layer| and |backend_factory| are managed by the HttpCache and
   // will be destroyed using |delete| when the HttpCache is destroyed.
   HttpCache(HttpTransactionFactory* network_layer,

[pauljensen, 2015/09/02 14:32:29]

ditto

[mmenke, 2015/09/02 16:29:34]

Acknowledged.

             NetLog* net_log,
-            BackendFactory* backend_factory);
+            BackendFactory* backend_factory,

[pauljensen, 2015/09/02 14:32:29]

ditto

[mmenke, 2015/09/02 16:29:33]

Acknowledged.

+            bool set_up_quic_server_info);
 
   ~HttpCache() override;
 
   HttpTransactionFactory* network_layer() { return network_layer_.get(); }
 
   DiskBasedCertCache* cert_cache() const { return cert_cache_.get(); }
 
   // Retrieves the cache backend for this HttpCache instance. If the backend
   // is not initialized yet, this method will initialize it. The return value is
   // a network error code, and it could be ERR_IO_PENDING, in which case the
@@ skipping 285 matching lines @@
   scoped_ptr<base::Clock> clock_;
 
   base::WeakPtrFactory<HttpCache> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(HttpCache);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_CACHE_H_