Chromium Code Reviews| Index: net/http/http_network_layer.h |
| diff --git a/net/http/http_network_layer.h b/net/http/http_network_layer.h |
| index 23b4e1eb2dba45c065fed2f38d9c6f9784c88f60..238d205431510b9854868ce2be45212d9f24c848 100644 |
| --- a/net/http/http_network_layer.h |
| +++ b/net/http/http_network_layer.h |
| @@ -26,18 +26,11 @@ class NET_EXPORT HttpNetworkLayer |
| NON_EXPORTED_BASE(public base::NonThreadSafe) { |
| public: |
| // Construct a HttpNetworkLayer with an existing HttpNetworkSession which |
| - // contains a valid ProxyService. |
| + // contains a valid ProxyService. The HttpTransactionFactory must be destroyed |
| + // the HttpNetworkSession. |
|
pauljensen
2015/09/02 14:32:29
You're missing a word here, perhaps "before".
mmenke
2015/09/02 16:29:34
Done.
|
| explicit HttpNetworkLayer(HttpNetworkSession* session); |
| ~HttpNetworkLayer() override; |
| - // Create a transaction factory that instantiate a network layer over an |
| - // existing network session. Network session contains some valuable |
| - // information (e.g. authentication data) that we want to share across |
| - // multiple network layers. This method exposes the implementation details |
| - // of a network layer, use this method with an existing network layer only |
| - // when network session is shared. |
| - static HttpTransactionFactory* CreateFactory(HttpNetworkSession* session); |
| - |
| // HttpTransactionFactory methods: |
| int CreateTransaction(RequestPriority priority, |
| scoped_ptr<HttpTransaction>* trans) override; |
| @@ -49,7 +42,7 @@ class NET_EXPORT HttpNetworkLayer |
| void OnResume() override; |
| private: |
| - const scoped_refptr<HttpNetworkSession> session_; |
| + HttpNetworkSession* session_; |
|
pauljensen
2015/09/02 14:32:29
nit: *->*const
mmenke
2015/09/02 16:29:34
Done.
|
| bool suspended_; |
| DISALLOW_COPY_AND_ASSIGN(HttpNetworkLayer); |