Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1297723004: Forgot to add resources with new test (Closed)

Created:
5 years, 4 months ago by msarett
Modified:
5 years, 4 months ago
Reviewers:
hal.canary, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Forgot to add resources with new test I created these images using mandrill_16.png (already in resources) and an online tool. https://codereview.chromium.org/1287863004/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/45cba08015bd21c14a850eae29f81951fdba4bed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A resources/16x1.png View Binary file 0 comments Download
A resources/1x1.png View Binary file 0 comments Download
A resources/1x16.png View Binary file 0 comments Download
A resources/1x3.png View Binary file 0 comments Download
A resources/2x2.png View Binary file 0 comments Download
A resources/3x1.png View Binary file 0 comments Download
A resources/3x3.png View Binary file 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
msarett
5 years, 4 months ago (2015-08-19 14:37:00 UTC) #2
hal.canary
lgtm
5 years, 4 months ago (2015-08-19 14:37:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297723004/1
5 years, 4 months ago (2015-08-19 14:37:55 UTC) #5
djsollen
lgtm
5 years, 4 months ago (2015-08-19 14:55:09 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 15:13:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/45cba08015bd21c14a850eae29f81951fdba4bed

Powered by Google App Engine
This is Rietveld 408576698